Skip to content

Commit

Permalink
[#26172] Added LinearProgress on refreshing the page of Migrations …
Browse files Browse the repository at this point in the history
…list (Voyager landing page).

Summary:
Added `LinearProgress` on refreshing the page.
Replaced `all` => `common.all`

Test Plan: Manual testing

Reviewers: djiang

Reviewed By: djiang

Subscribers: yugabyted-dev, krishna.tripathi

Differential Revision: https://phorge.dev.yugabyte.com/D42156
  • Loading branch information
krishna-yb committed Feb 26, 2025
1 parent 9858cd2 commit 800ffb3
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 34 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -536,7 +536,7 @@ export const MigrationList: FC<MigrationListProps> = ({
value={sourceEngine}
onChange={(e) => setSourceEngine(e.target.value)}
>
<MenuItem value="">All</MenuItem>
<MenuItem value="">{t("common.all")}</MenuItem>
<Divider className={classes.divider} />
<MenuItem value="PostgreSQL">PostgreSQL</MenuItem>
<MenuItem value="MySQL">MySQL</MenuItem>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -208,39 +208,38 @@ export const MigrationOverview: FC<MigrationOverviewProps> = () => {
)}
</Box>

{isLoadingMigrationTasks && (
<Box textAlign="center" pt={4} pb={4} width="100%">
<LinearProgress />
</Box>
)}

{!isLoadingMigrationTasks && (
<>
{(!selectedMigration && !isNewMigration) ? (
<MigrationList
migrationData={migrationData}
onSelectMigration={({ migration_uuid }) => setQueryParams({
migration_uuid,
new_migration: undefined,
})}
hasError={isErrorMigrationTasks}
onRefresh={refetch}
onNewMigration={() => setQueryParams({
migration_uuid: undefined,
new_migration: null
})}
/>
) : (
<MigrationDetails
steps={migrationSteps}
migration={selectedMigration}
onRefetch={refetch}
isFetching={isFetchingMigrationTasks}
isNewMigration={isNewMigration}
/>
)}
</>
)}
{(isLoadingMigrationTasks || isFetchingMigrationTasks) ? (
<Box textAlign="center" pt={4} pb={4} width="100%">
<LinearProgress />
</Box>
) : (
<>
{(!selectedMigration && !isNewMigration) ? (
<MigrationList
migrationData={migrationData}
onSelectMigration={({ migration_uuid }) => setQueryParams({
migration_uuid,
new_migration: undefined,
})}
hasError={isErrorMigrationTasks}
onRefresh={refetch}
onNewMigration={() => setQueryParams({
migration_uuid: undefined,
new_migration: null,
})}
/>
) : (
<MigrationDetails
steps={migrationSteps}
migration={selectedMigration}
onRefetch={refetch}
isFetching={isFetchingMigrationTasks}
isNewMigration={isNewMigration}
/>
)}
</>
)
}
</Box>
);
};

0 comments on commit 800ffb3

Please sign in to comment.