Skip to content

Commit

Permalink
[#16615] dev tools: Fix script compatibility with newer arcanist
Browse files Browse the repository at this point in the history
Summary:
Newer versions of arc commands require scripted (non-interactive) commands to include end of options
flag.

Test Plan:
Jenkins: skip
manual test

Reviewers: jharveysmith, skarri, odeshmukh

Reviewed By: odeshmukh

Subscribers: devops

Differential Revision: https://phabricator.dev.yugabyte.com/D23986
  • Loading branch information
svarnau committed Apr 3, 2023
1 parent 9ed9473 commit 765d8fe
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions arcanist_util/check-diff-name.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
arc_which_cmd = ['arc', 'which']
if args.base:
arc_which_cmd += ['--base', 'git:merge-base(origin/master)']
arc_which_cmd += ['--'] # end of options marker required
arc_which_out = check_output(arc_which_cmd, cwd=args.repository).decode('utf-8')
diff_descs = re.findall('D[0-9]+.*', arc_which_out)
if diff_descs:
Expand Down

0 comments on commit 765d8fe

Please sign in to comment.