Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "Save & Close Tabs" leaves the last tab open if tab space page is in the tabs #71

Open
znculee opened this issue Oct 6, 2021 · 1 comment

Comments

@znculee
Copy link

znculee commented Oct 6, 2021

Describe the bug
A clear and concise description of what the bug is.
It should be expected that after clicking "Save & Close Tabs", all tabs should be closed. However, if the tab space page is on, the last tab will not be closed as expected. The similar extension "one tab" doesn't have this issue.

To Reproduce
Steps to reproduce the behavior:

  1. Open tab space page.
  2. Restore and delete a set of tabs without manually close the tab space page.
  3. Click on "Save & Close Tabs".
  4. The last tab will not be closed, even though it should be saved successfully.

Desktop (please complete the following information):
Mac OS 11.6

@yuanzhoucq
Copy link
Owner

Thanks for the bug reporting.

Normally in this situation, the extension will activate the Tab Space page and close other tabs. But now the SFSafariTab.activate(completionHandler:) method stops working. It seems to be a bug of Safari. I will file this bug and think about an alternative way to solve this issue. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants