-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: pagination for source http #2847
Conversation
Will try to fix the CI checks |
ok not sure what to make of the as far as the module, it works as described in the first comment Please let me know what I can do to make the checks pass. Thanks |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2847 +/- ##
==========================================
- Coverage 66.55% 65.90% -0.66%
==========================================
Files 30 30
Lines 1507 1525 +18
==========================================
+ Hits 1003 1005 +2
- Misses 504 520 +16
☔ View full report in Codecov by Sentry. |
all checks passed! this is great!! |
This is ready to be merged 👍 |
Pre-Request Checklist
rubocop --auto-correct
)rake test
)Description
The burden of getting ALL data should not fall on the api but on the client.
We have several applications that use pagination and thought it was time for oxidized to have it too.
Basically adds two new settings to
source.http
.See documentation for details.
Does not break existing config settings who do not have these settings enabled.
Thanks
EDIT
forgot to mention that I am not a ruby dev, just a IT enthusiast. So any ruby code syntax suggestions are welcomed