Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BitChute] Back-port from yt-dlp and enhance #31019

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

dirkf
Copy link
Contributor

@dirkf dirkf commented Jun 10, 2022

Boilerplate: mixed code, improvement

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense, except where:
  • I am not the original author of this code but it is in public domain or released under Unlicense (see Description)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

This PR re-works the BitChute extractor module based on the yt-dlp version, which in turn derives from the yt-dl version and unmerged yt-dl PRs.

The functional improvements are

  • better extraction of videos (BitChuteIE)
  • better extraction of channels (BitchuteChannelIE)
  • added extraction of playlists (BitChutePlaylistIE)
  • all tests pass.

Specific changes, apart from those needed for the yt-dl platform include the following.

Throughout

  • relax regexes
  • refactor common functions in BitChuteBaseIE, inherited by other IEs

BitChute

BitChuteChannel

BitChutePlaylist

Also closes #26569, resolves #29531.

Update: now resolves #32198.

dirkf added 4 commits June 10, 2022 01:37
BitChute
* extract timestamp instead of upload date
* improve title and description extraction
BitChuteChannel
* fix listing entries
Throughout
* relax regexes
* listing: include NSFW if --age-limit 18 (or higher)
* single video: extract 'age_limit': 18 if NSFW
Resolves ytdl-org#24419
@dirkf dirkf mentioned this pull request May 16, 2023
5 tasks
dirkf added 2 commits January 13, 2025 13:00
* improve extraction based on yt-dlp
* unite playlist/channel extraction, pt 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant