-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BitChute] Back-port from yt-dlp and enhance #31019
Open
dirkf
wants to merge
8
commits into
ytdl-org:master
Choose a base branch
from
dirkf:df-bitchute-ovrhaul
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BitChute * extract timestamp instead of upload date * improve title and description extraction BitChuteChannel * fix listing entries Throughout * relax regexes
* listing: include NSFW if --age-limit 18 (or higher) * single video: extract 'age_limit': 18 if NSFW Resolves ytdl-org#24419
* resolves ytdl-org#28500
dirkf
commented
Feb 4, 2023
dirkf
commented
Feb 4, 2023
dirkf
commented
Feb 4, 2023
dirkf
commented
Feb 4, 2023
dirkf
commented
Feb 4, 2023
dirkf
commented
Feb 4, 2023
dirkf
commented
Feb 4, 2023
dirkf
commented
Jan 13, 2025
* improve extraction based on yt-dlp * unite playlist/channel extraction, pt 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boilerplate: mixed code, improvement
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This PR re-works the BitChute extractor module based on the yt-dlp version, which in turn derives from the yt-dl version and unmerged yt-dl PRs.
The functional improvements are
BitChuteIE
)BitchuteChannelIE
)BitChutePlaylistIE
)Specific changes, apart from those needed for the yt-dl platform include the following.
Throughout
BitChuteBaseIE
, inherited by other IEsBitChute
timestamp
instead ofupload_date
(resolves [bitchute] parse timestamp #24180, closes [bitchute] parse timestamp #24182)'age_limit': 18
if NSFWchannel_url
(resolves channel_url for Bitchute #28500)BitChuteChannel
--age-limit 18
(or higher) (resolves Bitchute: Failure to report "NSFW" videos when listing a channel #24419)BitChutePlaylist
BitChuteChannelIE
and PR [BitChutePlaylist] Add new extractor #26725 (resolves Add option to embed sub as synced lyrics tag. #29964, closes [BitChutePlaylist] Add new extractor #26725, would resolve [Bitchute] Playlist unrecognized yt-dlp/yt-dlp#2845)Also closes #26569, resolves #29531.
Update: now resolves #32198.