Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked into it, and replacing the callback for
without_wrapping
with aPreWriter
(or even just aW
) wouldn't be worth it. I'd still have to borrow againstself.words_buffer
, unless I wanted an even more complicated thing where the writes happen and then report back to the WordsBuffer how many chars go written without wrapping. That's certainly possible, but more complicated than I think is worthwhile.Instead, I added
#[must_use]
to the return ofset_word_boundary
. That gives me decent (if not perfect) protection against forgetting to restore it, and keeps things simple.While I was here, I cleaned up a bunch of
<W> ... where W:
's, and turned them intoimpl
.