Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-97 workaround for https://bugs.swift.org/browse/SR-1386 #159

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Kastet
Copy link
Contributor

@Kastet Kastet commented Apr 26, 2019

Fix for #153

Changes:

  • remove top level namespace
  • move coding options into a new Config namespace
  • pull tags, version and Server out to the top level
  • if no tags, create Operation namespace

Newly generated API library should not have many braking changes - only references to coding options would need to be updated - references to operations should continue working via the old namespace as it matches the module name.

Kostia Kim and others added 2 commits April 27, 2019 09:26
- remove top level namespace
- move coding options into a new Config namespace
- pull tags, version and Server out to the top level
- if no tags, create Operation namespace
Sync fork - support object in query params
@Kastet
Copy link
Contributor Author

Kastet commented May 14, 2019

@yonaskolb can you look at this when you have a chance?

@yonaskolb
Copy link
Owner

Thanks for this @Kastet, and sorry it's taken me so long to get around to this. As you know probably by now you can create your own template and point to that as well, so official SwagGen releases don't hold you up.

As this is a breaking change anyway, it would be nice to group the tags under something as well. I find the code completion really helps. You have Operation for tagless requests, they could go under there. I would also suggest the name Endpoint instead of Operation for both. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants