-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 使用eslint规范代码, 城市筛选添加本地缓存 #57
Closed
+3,439
−836
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9d11014
feat: 使用eslint规范代码, 城市筛选添加本地缓存
Night-stars-1 42805db
[autofix.ci] apply automated fixes
autofix-ci[bot] 93c2fbf
feat: 多行引用最后一行不保留, 代码结尾保留
Night-stars-1 b324022
feat: 多行引用最后一行不保留, 代码结尾保留
Night-stars-1 17e3b23
chore: 删除功能性更改
Night-stars-1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,191 @@ | ||
| module.exports = { | ||
| env: { | ||
| browser: true, | ||
| es2021: true | ||
| }, | ||
| extends: [ | ||
| '@antfu/eslint-config-vue', | ||
| 'plugin:vue/vue3-recommended', | ||
| 'plugin:import/recommended', | ||
| 'plugin:import/typescript', | ||
| 'plugin:promise/recommended', | ||
| 'plugin:sonarjs/recommended', | ||
| 'plugin:@typescript-eslint/recommended', | ||
| 'plugin:case-police/recommended' | ||
| ], | ||
| parser: 'vue-eslint-parser', | ||
| parserOptions: { | ||
| ecmaVersion: 13, | ||
| parser: '@typescript-eslint/parser', | ||
| sourceType: 'module' | ||
| }, | ||
| plugins: [ | ||
| 'vue', | ||
| '@typescript-eslint' | ||
| ], | ||
| ignorePatterns: ['node_modules', 'dist', '*.d.ts', 'vendor'], | ||
| rules: { | ||
| 'no-console': process.env.NODE_ENV === 'production' ? 'warn' : 'off', | ||
| 'no-debugger': process.env.NODE_ENV === 'production' ? 'warn' : 'off', | ||
|
|
||
| // indentation (Already present in TypeScript) | ||
| 'comma-spacing': ['error', { before: false, after: true }], | ||
| 'key-spacing': ['error', { afterColon: true }], | ||
| 'n/prefer-global/process': ['off'], | ||
| 'sonarjs/cognitive-complexity': ['off'], | ||
|
|
||
| 'vue/first-attribute-linebreak': ['error', { | ||
| singleline: 'beside', | ||
| multiline: 'below' | ||
| }], | ||
|
|
||
| 'antfu/top-level-function': 'off', | ||
| '@typescript-eslint/no-explicit-any': 'off', | ||
|
|
||
| // indentation (Already present in TypeScript) | ||
| 'indent': ['error', 2], | ||
|
|
||
| // Enforce trailing comma (Already present in TypeScript) | ||
| 'comma-dangle': 'off', | ||
| '@typescript-eslint/comma-dangle': ['error', 'never'], | ||
|
|
||
| // Enforce consistent spacing inside braces of object (Already present in TypeScript) | ||
| 'object-curly-spacing': ['error', 'always'], | ||
|
|
||
| // Enforce camelCase naming convention | ||
| 'camelcase': 'error', | ||
|
|
||
| // Disable max-len | ||
| 'max-len': 'off', | ||
|
|
||
| // we don't want it | ||
| 'semi': 'off', | ||
| '@typescript-eslint/semi': ['error', 'always'], | ||
|
|
||
| // add parens ony when required in arrow function | ||
| 'arrow-parens': ['error', 'as-needed'], | ||
|
|
||
| // add new line above comment | ||
| 'newline-before-return': 'error', | ||
|
|
||
| // add new line above comment | ||
| 'lines-around-comment': [ | ||
| 'error', | ||
| { | ||
| beforeBlockComment: true, | ||
| beforeLineComment: true, | ||
| allowBlockStart: true, | ||
| allowClassStart: true, | ||
| allowObjectStart: true, | ||
| allowArrayStart: true, | ||
|
|
||
| // We don't want to add extra space above closing SECTION | ||
| ignorePattern: '!SECTION' | ||
| } | ||
| ], | ||
|
|
||
| // Ignore _ as unused variable | ||
| '@typescript-eslint/no-unused-vars': ['error', { varsIgnorePattern: '^_+$', argsIgnorePattern: '^_+$' }], | ||
|
|
||
| 'array-element-newline': ['error', 'consistent'], | ||
| 'array-bracket-newline': ['error', 'consistent'], | ||
|
|
||
| 'vue/multi-word-component-names': 'off', | ||
|
|
||
| 'padding-line-between-statements': [ | ||
| 'error', | ||
| { blankLine: 'always', prev: 'expression', next: 'const' }, | ||
| { blankLine: 'always', prev: 'const', next: 'expression' }, | ||
| { blankLine: 'always', prev: 'multiline-const', next: '*' }, | ||
| { blankLine: 'always', prev: '*', next: 'multiline-const' } | ||
| ], | ||
|
|
||
| // Plugin: eslint-plugin-import | ||
| 'import/prefer-default-export': 'off', | ||
| 'import/newline-after-import': ['error', { count: 1 }], | ||
| 'no-restricted-imports': ['error', 'vuetify/components', { | ||
| name: 'vue3-apexcharts', | ||
| message: 'apexcharts are autoimported' | ||
| }], | ||
|
|
||
| // For omitting extension for ts files | ||
| 'import/extensions': [ | ||
| 'error', | ||
| 'ignorePackages', | ||
| { | ||
| js: 'never', | ||
| jsx: 'never', | ||
| ts: 'never', | ||
| tsx: 'never' | ||
| } | ||
| ], | ||
|
|
||
| // ignore virtual files | ||
| 'import/no-unresolved': [2, { | ||
| ignore: [ | ||
| '~pages$', | ||
| 'virtual:generated-layouts', | ||
|
|
||
| // Ignore vite's ?raw imports | ||
| '.*\?raw' | ||
| ] | ||
| }], | ||
|
|
||
| // Thanks: https://stackoverflow.com/a/63961972/10796681 | ||
| 'no-shadow': 'off', | ||
| '@typescript-eslint/no-shadow': ['error'], | ||
|
|
||
| '@typescript-eslint/consistent-type-imports': 'error', | ||
|
|
||
| // Plugin: eslint-plugin-promise | ||
| 'promise/always-return': 'off', | ||
| 'promise/catch-or-return': 'off', | ||
|
|
||
| // ESLint plugin vue | ||
| 'vue/block-tag-newline': 'error', | ||
| 'vue/component-api-style': 'off', | ||
| 'vue/component-name-in-template-casing': ['error', 'PascalCase', { registeredComponentsOnly: false, ignores: ['/^swiper-/'] }], | ||
| 'vue/custom-event-name-casing': ['error', 'camelCase', { | ||
| ignores: [ | ||
| '/^(click):[a-z]+((\d)|([A-Z0-9][a-z0-9]+))*([A-Z])?/' | ||
| ] | ||
| }], | ||
| 'vue/define-macros-order': 'error', | ||
| 'vue/html-comment-content-newline': 'error', | ||
| 'vue/html-comment-content-spacing': 'error', | ||
| 'vue/html-comment-indent': 'error', | ||
| 'vue/match-component-file-name': 'error', | ||
| 'vue/no-child-content': 'error', | ||
| 'vue/require-default-prop': 'off', | ||
|
|
||
| 'vue/no-duplicate-attr-inheritance': 'error', | ||
| 'vue/no-empty-component-block': 'error', | ||
| 'vue/no-multiple-objects-in-class': 'error', | ||
| 'vue/no-reserved-component-names': 'error', | ||
| 'vue/no-template-target-blank': 'error', | ||
| 'vue/no-useless-mustaches': 'error', | ||
| 'vue/no-useless-v-bind': 'error', | ||
| 'vue/padding-line-between-blocks': 'error', | ||
| 'vue/prefer-separate-static-class': 'error', | ||
| 'vue/prefer-true-attribute-shorthand': 'error', | ||
| 'vue/v-on-function-call': 'error', | ||
| 'vue/no-restricted-class': ['error'], | ||
| 'vue/valid-v-slot': ['error', { | ||
| allowModifiers: true | ||
| }], | ||
|
|
||
| // -- Extension Rules | ||
| 'vue/no-irregular-whitespace': 'error', | ||
| 'vue/template-curly-spacing': 'error', | ||
|
|
||
| // -- Sonarlint | ||
| 'sonarjs/no-duplicate-string': 'off', | ||
| 'sonarjs/no-nested-template-literals': 'off' | ||
| }, | ||
| settings: { | ||
| 'import/resolver': { | ||
| node: true, | ||
| typescript: {} | ||
| } | ||
| } | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| { | ||
| "editor.formatOnSave": true, | ||
| "files.insertFinalNewline": true, | ||
| "javascript.updateImportsOnFileMove.enabled": "always", | ||
| "[javascript]": { | ||
| "editor.defaultFormatter": "dbaeumer.vscode-eslint" | ||
| }, | ||
| "[typescript]": { | ||
| "editor.defaultFormatter": "dbaeumer.vscode-eslint", | ||
| "editor.autoClosingBrackets": "always" | ||
| }, | ||
| "[vue]": { | ||
| "editor.defaultFormatter": "dbaeumer.vscode-eslint", | ||
| }, | ||
| // Extension: ESLint | ||
| "editor.codeActionsOnSave": { | ||
| "source.fixAll.eslint": "explicit", | ||
| }, | ||
| "eslint.format.enable": true | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个语义一致吗，会多空格吗？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多空格其实也不影响，不过这个换行确实有点奇怪，ESlint应该也是可配置的