Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement "Add option to make all window in overview be rounded" #151

Conversation

sidevesh
Copy link

@sidevesh sidevesh commented Feb 10, 2024

Closes #93

@ifelsemaybe
Copy link

Works on my machine.

@sidevesh
Copy link
Author

sidevesh commented Mar 6, 2024

I have just migrated the original code written by @yilozt on a branch but never merged to Gnome 45,
not sure why @yilozt is non responsive on this since almost a year despite writing the original code and taking the effort to upgrade the extension to Gnome 45 a while back.
@yilozt It would be great if you can merge this in so I can stop having to maintain this branch.

@ifelsemaybe
Copy link

They might just be busy. Sometimes life gets in the way man.

@ifelsemaybe
Copy link

Actually, one bug I'm noticing with your branch is that when I go in the overview, all the windows are blurred for some reason. If I disable the "Add rounded corners for all windows in overview" setting, inside Extensions, that blur disappears. So something is up. While scrolling through the commit history, I saw that this bug has been addressed before, 02f0ae8. Maybe this can offer some insight...

@ifelsemaybe
Copy link

While testing this issue a little further, I believe the blur shows itself in the overview to all windows that have rounded corners. So on the main branch, a window that has not been maximized, and shows up by default, rounded, in the overview, will also have this same problem. I might raise an issue for this, if it hasn't already been raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Round maximized and tiled windows in overview
2 participants