Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change QueueInterface::getChannel() result type to string only #239

Merged
merged 8 commits into from
Feb 14, 2025

Conversation

vjik
Copy link
Member

@vjik vjik commented Jan 27, 2025

Q A
Is bugfix?
New feature?
Breaks BC? ✔️

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.09%. Comparing base (4561dde) to head (7f19a30).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #239      +/-   ##
============================================
+ Coverage     92.87%   93.09%   +0.21%     
  Complexity      359      359              
============================================
  Files            47       47              
  Lines           969      970       +1     
============================================
+ Hits            900      903       +3     
+ Misses           69       67       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik requested a review from a team January 27, 2025 14:28
@vjik vjik added the status:code review The pull request needs review. label Jan 27, 2025
@samdark samdark requested a review from viktorprogger January 28, 2025 10:50
@viktorprogger
Copy link
Contributor

@vjik What's the purpose of channels without adapters? Before this change a channel is a configured adapter.

@vjik
Copy link
Member Author

vjik commented Feb 9, 2025

@vjik What's the purpose of channels without adapters? Before this change a channel is a configured adapter.

Before this change queue also could be without adapter. See code in master branch.

@vjik vjik merged commit 05ab1c0 into master Feb 14, 2025
26 checks passed
@vjik vjik deleted the improve-queue-interface branch February 14, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants