Eliminate return value

yiisoft · Dec 25, 2023 · 4a31aac · 4a31aac
1 parent ca8a20f
commit 4a31aac
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 10 deletions.
diff --git a/src/Message/MessageHandlerInterface.php b/src/Message/MessageHandlerInterface.php
@@ -6,5 +6,5 @@
 
 interface MessageHandlerInterface
 {
-    public function handle(MessageInterface $message): MessageInterface;
+    public function handle(MessageInterface $message): void;
 }
diff --git a/tests/App/FakeHandler.php b/tests/App/FakeHandler.php
@@ -32,10 +32,8 @@ public function executeWithException(MessageInterface $message): void
         throw new RuntimeException('Test exception');
     }
 
-    public function handle(MessageInterface $message): MessageInterface
+    public function handle(MessageInterface $message): void
     {
         self::$processedMessages[] = $message;
-
-        return $message;
     }
 }
diff --git a/tests/Support/ExceptionMessageHandler.php b/tests/Support/ExceptionMessageHandler.php
@@ -10,7 +10,7 @@
 
 class ExceptionMessageHandler implements MessageHandlerInterface
 {
-    public function handle(MessageInterface $message): MessageInterface
+    public function handle(MessageInterface $message): void
     {
         throw new RuntimeException('Test exception');
     }

diff --git a/tests/Support/NullMessageHandler.php b/tests/Support/NullMessageHandler.php
@@ -9,8 +9,7 @@
 
 class NullMessageHandler implements MessageHandlerInterface
 {
-    public function handle(MessageInterface $message): MessageInterface
+    public function handle(MessageInterface $message): void
     {
-        return $message;
     }
 }
diff --git a/tests/Support/StackMessageHandler.php b/tests/Support/StackMessageHandler.php
@@ -11,10 +11,8 @@ class StackMessageHandler implements MessageHandlerInterface
 {
     public array $processedMessages = [];
 
-    public function handle(MessageInterface $message): MessageInterface
+    public function handle(MessageInterface $message): void
     {
         $this->processedMessages[] = $message;
-
-        return $message;
     }
 }