Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #2332: pass knitr::asis_output() to the output hook #2365

Merged
merged 3 commits into from
Sep 20, 2024
Merged

fix #2332: pass knitr::asis_output() to the output hook #2365

merged 3 commits into from
Sep 20, 2024

Conversation

yihui
Copy link
Owner

@yihui yihui commented Sep 19, 2024

and every output hook should check if the chunk option results == 'asis'

@yihui
fix #2332: pass knitr::asis_output() to the output hook, and every …
9d80301 
…`output` hook should check if the chunk option `results == 'asis'`
@yihui yihui linked an issue Sep 19, 2024 that may be closed by this pull request
Make asis_output works for Quarto the same as results: asis #2332
Closed
@yihui yihui requested a review from cderv September 19, 2024 18:56
cderv
cderv approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW our current tests are passing with this PR.

I need to think more about the potential problem, but I think we do already overwrite knitr's output hook in Quarto to do just this.

So I think this is all good.

@yihui
Copy link
Owner Author

yihui commented Sep 20, 2024

Okay, I'll merge it for now.

@yihui yihui merged commit 7e9afd1 into master Sep 20, 2024
1 check passed
@yihui yihui deleted the fix-2332 branch September 20, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cderv cderv cderv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make asis_output works for Quarto the same as results: asis
2 participants
@yihui @cderv