Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

returned field methods to public #1531

Merged
merged 1 commit into from
Oct 25, 2024
Merged

returned field methods to public #1531

merged 1 commit into from
Oct 25, 2024

Conversation

rekby
Copy link
Member

@rekby rekby commented Oct 25, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Copy link

github.com/ydb-platform/ydb-go-sdk/v3/log

compatible changes

Any: added
Bool: added
Duration: added
Error: added
Int64: added
Int: added
NamedError: added
String: added
Stringer: added
Strings: added

summary

Base version: v3.89.1 (master)
Suggested version: v3.90.0

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 70.88%. Comparing base (25a0667) to head (c5fb45e).

Files with missing lines Patch % Lines
log/field.go 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1531      +/-   ##
==========================================
- Coverage   70.93%   70.88%   -0.06%     
==========================================
  Files         356      356              
  Lines       37490    37510      +20     
==========================================
- Hits        26594    26588       -6     
- Misses       9787     9813      +26     
  Partials     1109     1109              
Flag Coverage Δ
experiment 70.77% <0.00%> (+0.01%) ⬆️
go-1.21.x 70.41% <0.00%> (+0.05%) ⬆️
go-1.22.x 68.36% <0.00%> (-0.06%) ⬇️
go-1.23.x 70.87% <0.00%> (-0.01%) ⬇️
integration 52.29% <0.00%> (-0.06%) ⬇️
macOS 40.89% <0.00%> (-0.01%) ⬇️
ubuntu 70.88% <0.00%> (-0.06%) ⬇️
unit 40.91% <0.00%> (-0.03%) ⬇️
windows 40.87% <0.00%> (-0.05%) ⬇️
ydb-23.3 47.95% <0.00%> (+0.03%) ⬆️
ydb-24.1 52.15% <0.00%> (+0.26%) ⬆️
ydb-24.2 52.06% <0.00%> (-0.14%) ⬇️
ydb-nightly 70.77% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

Copy link

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

@rekby rekby merged commit d09736f into master Oct 25, 2024
44 checks passed
@rekby rekby deleted the fix-log-fields branch October 25, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants