Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* gRPC connection will be forcefully closed on DNS resolver errors from now on #1529

Closed
wants to merge 1 commit into from

Conversation

asmyasnikov
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov added bug Something isn't working refactoring grpc DNS labels Oct 24, 2024
@asmyasnikov asmyasnikov self-assigned this Oct 24, 2024
Copy link

summary

Base version: v3.88.1-0.20241024131607-6afc9a7927d2 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.88.0.

Copy link

github-actions bot commented Oct 24, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

github-actions bot commented Oct 24, 2024

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

github-actions bot commented Oct 24, 2024

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

github-actions bot commented Oct 24, 2024

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

github-actions bot commented Oct 24, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 23.21429% with 86 lines in your changes missing coverage. Please review.

Project coverage is 40.87%. Comparing base (2e44601) to head (fa2f831).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
internal/conn/pool.go 0.00% 53 Missing ⚠️
internal/balancer/balancer.go 42.85% 31 Missing and 1 partial ⚠️
internal/conn/conn.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (2e44601) and HEAD (fa2f831). Click for more details.

HEAD has 505 uploads less than BASE
Flag BASE (2e44601) HEAD (fa2f831)
macOS 24 3
unit 72 9
go-1.21.x 48 3
go-1.22.x 48 3
ubuntu 103 3
go-1.23.x 55 3
windows 24 3
integration 72 0
ydb-23.3 24 0
ydb-24.2 24 0
ydb-24.1 24 0
ydb-nightly 7 0
experiment 7 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1529       +/-   ##
===========================================
- Coverage   70.99%   40.87%   -30.12%     
===========================================
  Files         356      355        -1     
  Lines       37483    37338      -145     
===========================================
- Hits        26611    15263    -11348     
- Misses       9768    21568    +11800     
+ Partials     1104      507      -597     
Flag Coverage Δ
experiment ?
go-1.21.x 42.40% <21.81%> (-28.09%) ⬇️
go-1.22.x 40.86% <23.21%> (-27.68%) ⬇️
go-1.23.x 40.85% <23.21%> (-30.15%) ⬇️
integration ?
macOS 40.86% <23.21%> (-0.08%) ⬇️
ubuntu 40.85% <23.21%> (-30.14%) ⬇️
unit 40.87% <23.21%> (-0.08%) ⬇️
windows 40.87% <23.21%> (-0.07%) ⬇️
ydb-23.3 ?
ydb-24.1 ?
ydb-24.2 ?
ydb-nightly ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DNS grpc refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants