Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace.{}.Compose now can be called on nil #1526

Merged
merged 1 commit into from
Oct 23, 2024
Merged

trace.{}.Compose now can be called on nil #1526

merged 1 commit into from
Oct 23, 2024

Conversation

asmyasnikov
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov self-assigned this Oct 23, 2024
Copy link

summary

Base version: v3.87.0 (master)
Suggested version: v3.87.1

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.96%. Comparing base (9be2f13) to head (7420bcf).
Report is 69 commits behind head on master.

Files with missing lines Patch % Lines
internal/cmd/gtrace/writer.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1526      +/-   ##
==========================================
+ Coverage   70.91%   70.96%   +0.05%     
==========================================
  Files         356      356              
  Lines       37190    37536     +346     
==========================================
+ Hits        26373    26639     +266     
- Misses       9717     9787      +70     
- Partials     1100     1110      +10     
Flag Coverage Δ
experiment 70.83% <0.00%> (+0.07%) ⬆️
go-1.21.x 70.43% <ø> (+0.10%) ⬆️
go-1.22.x 68.43% <0.00%> (+0.08%) ⬆️
go-1.23.x 70.96% <0.00%> (+0.10%) ⬆️
integration 52.17% <ø> (-0.08%) ⬇️
macOS 41.02% <0.00%> (+0.13%) ⬆️
ubuntu 70.96% <0.00%> (+0.05%) ⬆️
unit 41.02% <0.00%> (+0.11%) ⬆️
windows 40.98% <0.00%> (+0.07%) ⬆️
ydb-23.3 47.83% <ø> (+0.03%) ⬆️
ydb-24.1 52.07% <ø> (-0.02%) ⬇️
ydb-24.2 52.04% <ø> (-0.15%) ⬇️
ydb-nightly 70.83% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmyasnikov asmyasnikov merged commit 8e1c411 into master Oct 23, 2024
42 checks passed
@asmyasnikov asmyasnikov deleted the nil-compose branch October 23, 2024 13:24
Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

Copy link

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants