for review only #1514
for review only #1514
Conversation
# Conflicts: # internal/bind/params.go
# Conflicts: # internal/table/scanner/scanner.go # internal/value/value.go # tests/integration/database_sql_regression_test.go
# Conflicts: # internal/scanner/scanner.go
github.com/ydb-platform/ydb-go-sdk/v3/table/typesincompatible changesUUIDValue: removed compatible changesErrIssue1501BadUUID: added summaryBase version: v3.85.2-0.20241022141519-53817cb7298d (uuid-fix) |
# Conflicts: # tests/integration/database_sql_regression_test.go
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## uuid-fix #1514 +/- ##
=============================================
+ Coverage 41.10% 52.15% +11.04%
=============================================
Files 355 349 -6
Lines 37397 36014 -1383
=============================================
+ Hits 15373 18783 +3410
+ Misses 21510 15999 -5511
- Partials 514 1232 +718
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| return nil | ||
| }) | ||
|
|
||
| require.NoError(t, err) |
There was a problem hiding this comment.
Should we remove these tests or check for Error instead?
There was a problem hiding this comment.
I removed some functions and the code cause compile error.
I don't know how to test in CI :(
# Conflicts: # internal/params/parameters.go # table/types/value.go
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information