Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added experimental package spans with abstract layer for tracing #1509

Merged
merged 9 commits into from
Oct 21, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix review issues
  • Loading branch information
asmyasnikov committed Oct 21, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit ebc4907911b0e0fa150dbdba43999cff72a49312
19 changes: 11 additions & 8 deletions spans/discovery.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package spans

import (
"fmt"

"github.com/ydb-platform/ydb-go-sdk/v3/internal/kv"
"github.com/ydb-platform/ydb-go-sdk/v3/trace"
)
@@ -17,15 +19,16 @@ func discovery(adapter Adapter) (t trace.Discovery) {
)

return func(info trace.DiscoveryDiscoverDoneInfo) {
endpoints := make([]string, len(info.Endpoints))
for i, e := range info.Endpoints {
endpoints[i] = e.String()
if info.Error != nil {
start.Error(info.Error)
} else {
endpoints := make([]string, len(info.Endpoints))
for i, e := range info.Endpoints {
endpoints[i] = e.String()
}
start.Log(fmt.Sprintf("endpoints=%v", endpoints))
}
finish(
start,
info.Error,
kv.Strings("endpoints", endpoints),
)
start.End()
}
}

6 changes: 3 additions & 3 deletions spans/driver.go
Original file line number Diff line number Diff line change
@@ -298,11 +298,11 @@ func driver(adapter Adapter) trace.Driver { //nolint:gocyclo,funlen
for i, e := range info.Dropped {
dropped[i] = e.String()
}
start.Log(fmt.Sprintf("endpoints=%v", endpoints))
start.Log(fmt.Sprintf("added=%v", added))
start.Log(fmt.Sprintf("dropped=%v", dropped))
start.End(
kv.String("local_dc", info.LocalDC),
kv.Strings("endpoints", endpoints),
kv.Strings("added", added),
kv.Strings("dropped", dropped),
)
}
},
2 changes: 0 additions & 2 deletions spans/scripting.go
Original file line number Diff line number Diff line change
@@ -14,7 +14,6 @@ func scripting(adapter Adapter) (t trace.Scripting) {
info.Context,
info.Call.FunctionID(),
kv.String("query", info.Query),
kv.String("params", safeStringer(info.Parameters)),
)

return func(info trace.ScriptingExecuteDoneInfo) {
@@ -47,7 +46,6 @@ func scripting(adapter Adapter) (t trace.Scripting) {
info.Context,
info.Call.FunctionID(),
kv.String("query", info.Query),
kv.String("params", safeStringer(info.Parameters)),
)

return func(
Loading