Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests + added integration tests for YDB 24.2 #1474

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

asmyasnikov
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov added bug Something isn't working CI labels Sep 18, 2024
@asmyasnikov asmyasnikov self-assigned this Sep 18, 2024
Copy link

github.com/ydb-platform/ydb-go-sdk/v3

incompatible changes

Version: value changed from "3.80.7" to "3.80.8"

compatible changes

WithLazyTx: added

summary

Base version: v3.80.8-0.20240918174755-2dad31159c09 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.80.8.

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.98%. Comparing base (9cd2f73) to head (613f294).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1474      +/-   ##
==========================================
+ Coverage   67.93%   67.98%   +0.04%     
==========================================
  Files         352      352              
  Lines       36420    36420              
==========================================
+ Hits        24741    24759      +18     
+ Misses      10595    10579      -16     
+ Partials     1084     1082       -2     
Flag Coverage Δ
experiment 72.14% <ø> (-0.07%) ⬇️
go-1.21.x 68.19% <ø> (+3.32%) ⬆️
go-1.22.x 65.70% <ø> (+2.37%) ⬆️
go-1.23.x 67.90% <ø> (+0.03%) ⬆️
integration 54.23% <ø> (+6.66%) ⬆️
macOS 40.89% <ø> (-0.01%) ⬇️
ubuntu 72.44% <ø> (+0.06%) ⬆️
unit 41.34% <ø> (ø)
windows 41.33% <ø> (-0.02%) ⬇️
ydb-23.3 47.53% <ø> (-0.04%) ⬇️
ydb-24.1 54.05% <ø> (?)
ydb-24.2 54.11% <ø> (?)
ydb-nightly 72.14% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

@asmyasnikov asmyasnikov merged commit 8616284 into master Sep 18, 2024
43 of 44 checks passed
@asmyasnikov asmyasnikov deleted the fix-tests branch September 18, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants