Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unmarshal row sugar #1460

Merged
merged 6 commits into from
Sep 18, 2024
Merged

unmarshal row sugar #1460

merged 6 commits into from
Sep 18, 2024

Conversation

rekby
Copy link
Member

@rekby rekby commented Sep 13, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Copy link

github-actions bot commented Sep 13, 2024

summary

Base version: v3.80.8-0.20240918151917-efa13b20da2c (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.80.7.

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.91%. Comparing base (3df3075) to head (ae811f3).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
sugar/query.go 77.27% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1460      +/-   ##
==========================================
+ Coverage   67.90%   67.91%   +0.01%     
==========================================
  Files         350      350              
  Lines       36314    36315       +1     
==========================================
+ Hits        24658    24663       +5     
+ Misses      10572    10569       -3     
+ Partials     1084     1083       -1     
Flag Coverage Δ
experiment 72.10% <85.71%> (+0.05%) ⬆️
go-1.21.x 68.08% <24.13%> (+0.01%) ⬆️
go-1.22.x 65.70% <24.13%> (-0.04%) ⬇️
go-1.23.x 67.85% <82.75%> (+0.08%) ⬆️
integration 53.88% <33.33%> (+0.01%) ⬆️
macOS 40.99% <76.19%> (-0.01%) ⬇️
ubuntu 72.32% <85.71%> (+0.01%) ⬆️
unit 41.43% <75.86%> (-0.01%) ⬇️
windows 41.42% <75.86%> (-0.02%) ⬇️
ydb-23.3 47.65% <0.00%> (+0.01%) ⬆️
ydb-24.1 53.87% <33.33%> (+0.16%) ⬆️
ydb-nightly 72.10% <85.71%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 13, 2024

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

github-actions bot commented Sep 13, 2024

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

Copy link

github-actions bot commented Sep 13, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over query-service:

Grafana Dashboard

SLO-native-query

Copy link

github-actions bot commented Sep 13, 2024

🌋 Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

Copy link

github-actions bot commented Sep 13, 2024

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

@asmyasnikov asmyasnikov merged commit efa13b2 into master Sep 18, 2024
21 checks passed
@asmyasnikov asmyasnikov deleted the struct-read-helpers branch September 18, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants