Skip to content

Commit

Permalink
comments
Browse files Browse the repository at this point in the history
  • Loading branch information
asmyasnikov committed Oct 21, 2024
1 parent 0a77e83 commit ee04de8
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
* Added experimental package `spans` with tracing adapter interfaces for OpenTelemetry, OpenTracing, etc.
* Added `db.Topic().DescribeTopicConsumer()` method for displaying consumer information
* Marked as deprecated options `ydb.WithDatabase(database)` and `ydb.WithEndpoint(endpoint)`

Expand Down
11 changes: 10 additions & 1 deletion spans/spans.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,13 @@ import (
)

type (
// KeyValue is key-value attribute for attaching into span
KeyValue = kv.KeyValue
Span interface {

// Span is an interface of spans in specific tracing system
//
// Experimental: https://github.com/ydb-platform/ydb-go-sdk/blob/master/VERSIONING.md#experimental
Span interface {
TraceID() (_ string, valid bool)

Link(link Span, attributes ...KeyValue)
Expand All @@ -20,6 +25,10 @@ type (

End(attributes ...KeyValue)
}

// Adapter is interface of specific tracing system adapters
//
// Experimental: https://github.com/ydb-platform/ydb-go-sdk/blob/master/VERSIONING.md#experimental
Adapter interface {
trace.Detailer

Expand Down

0 comments on commit ee04de8

Please sign in to comment.