Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix CI pipeline #1707

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

ssiegel
Copy link

@ssiegel ssiegel commented Feb 28, 2025

I wouldn't normally expect this to be my responsibility to fix, but given the state of the project, I felt compelled to step in so that we can finally move forward with other PRs like #1619, #1672, #1673, and #1674. It's disappointing to see a company-backed project in this condition, with crucial issues left unaddressed for so long. At the very least, this should help clean things up and make it easier to take CI results seriously again.

@fabclmnt fabclmnt self-requested a review March 3, 2025 21:50
@fabclmnt fabclmnt requested a review from portellaa March 3, 2025 22:31
@ssiegel
Copy link
Author

ssiegel commented Mar 3, 2025

The current test failures are caused by IPython 9 (IPython being a transitive dependency of nbval in requirements-test.txt), something #1709 tries to fix. A quick workaround for the tests might be to add a ipython<9 constraint into requirements-test.txt. Should I add that?

@fabclmnt
Copy link
Contributor

fabclmnt commented Mar 3, 2025

The current test failures are caused by IPython 9 (IPython being a transitive dependency of nbval in requirements-test.txt), something #1709 tries to fix. A quick workaround for the tests might be to add a ipython<9 constraint into requirements-test.txt. Should I add that?

Sounds good as a workaround for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants