Useful pylint fixes #1715
Open
Useful pylint fixes #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstaletic
force-pushed
the
pylint-manual
branch
from
06a41bd to
376fba1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1715 +/- ##
==========================================
+ Coverage 95.52% 95.95% +0.43%
==========================================
Files 52 84 +32
Lines 6975 8462 +1487
Branches 0 163 +163
==========================================
+ Hits 6663 8120 +1457
+ Misses 312 292 -20
- Partials 0 50 +50 |
puremourning
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Reviewed 29 of 29 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @bstaletic)
bstaletic
force-pushed
the
pylint-manual
branch
from
376fba1 to
3e56747
Compare
bstaletic
commented
Sep 17, 2024
There was a problem hiding this comment.
Rebased. I'll take a look at the changes once again tomorrow.
Reviewable status: 0 of 2 LGTMs obtained (and 1 stale) (waiting on @puremourning)
After combing through all the stuff pylint has found, this seems to me the useful part. The only questionable thing here, I think, could be the stuff related to `open()` and explicit encoding argument. This changes behaviour! Without specifying, the encoding is platform dependent. See https://docs.python.org/3/library/functions.html#open for details. Fixes ycm-core#1672
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After combing through all the stuff pylint has found, this seems to me the useful part.
The only questionable thing here, I think, could be the stuff related to
open()and explicit encoding argument. This changes behaviour! Without specifying, the encoding is platform dependent. See https://docs.python.org/3/library/functions.html#open for details.Fixes #1672
The dead code in python completer (see #1672) is removed in this pull request.
This change is