feat : added scroll bar component #49
Open
+111
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yashchaudhari008 k i'll work on it . could you please considers this PR under #hacktoberfest-accepted , #hacktoberfest2024 , gssoc-ext , gssoc2024-ext. |
|
@yashchaudhari008 i have updated it . See if its correct. Could you please consider this PR under hacktoberfest-accepted , gssoc2024-ext |
|
@yashchaudhari008 . Review my PR and merge . Consider this under hactoberfest-accepteed , gssoc-ext. |
| @@ -21,7 +21,8 @@ | |||
| "react": "^18.2.0", | |||
| "react-dnd": "^16.0.1", | |||
| "react-dnd-html5-backend": "^16.0.1", | |||
| "react-dom": "^18.2.0" | |||
| "react-dom": "^18.2.0", | |||
| "styled-components": "^6.1.13" | |||
There was a problem hiding this comment.
styles components is not needed
| @@ -0,0 +1,19 @@ | |||
| /* Global Scrollbar Styling */ | |||
| body::-webkit-scrollbar { | |||
There was a problem hiding this comment.
using body will not make it global, please check
There was a problem hiding this comment.
This file should not have any changes as no new package is needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve created the scroll bar component, along with an example to demonstrate its functionality. Please let me know if it meets your expectations. @yashchaudhari008 I'm eager to contribute further to your project and would appreciate your consideration for sponsorship to support my work. I look forward to your feedback. could you also be kind enough to consider my PR under hacktoberfest2024