Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update timing strategy #75

Open
plantfansam opened this issue Apr 18, 2023 · 0 comments
Open

Update timing strategy #75

plantfansam opened this issue Apr 18, 2023 · 0 comments

Comments

@plantfansam
Copy link
Contributor

A comment in opentelemetry-ruby reads:

      # Times are hard. Whenever an explicit timestamp is provided
      # (for Events or for the Span start_timestamp or end_timestamp),
      # we use that as the recorded timestamp. An implicit Event timestamp
      # and end_timestamp is computed as a monotonic clock offset from
      # the realtime start_timestamp. The realtime start_timestamp is
      # computed as a monotonic clock offset from the realtime
      # start_timestamp of its parent span, if available, or it is
      # fetched from the realtime system clock.
      #
      # We therefore have 3 start timestamps. The first two are used
      # internally (and by child spans) to compute other timestamps.
      # The last is the start timestamp actually recorded in the
      # SpanData.

I think we should update opentelemetry-lua to mirror the strategy in opentelemetry-ruby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant