feat: Enhance default ignore patterns #322
Conversation
Deploying repomix with
|
| Latest commit: |
423872c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ca3bd6eb.repomix.pages.dev |
| Branch Preview URL: | https://feat-ignore.repomix.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
==========================================
+ Coverage 90.14% 90.19% +0.05%
==========================================
Files 48 48
Lines 2475 2488 +13
Branches 514 514
==========================================
+ Hits 2231 2244 +13
Misses 244 244 ☔ View full report in Codecov by Sentry. |
📝 WalkthroughWalkthroughThe pull request modifies the
The overall structure of the ignore list remains consistent, with the changes focusing on expanding and reorganizing the ignored file types. Possibly related PRs
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/config/defaultIgnore.ts (1)
149-163: Consider adding more language-specific ignore patterns.While the addition of lock files for PHP, Ruby, Go, Elixir, and Haskell is good, consider adding other common patterns for these languages:
// Essential PHP-related entries '**/composer.lock', +'**/vendor/**', +'**/.phpunit.cache/**', // Essential Ruby-related entries '**/Gemfile.lock', +'**/.bundle/**', +'**/vendor/bundle/**', // Essential Go-related entries '**/go.sum', +'**/vendor/**', // Essential Elixir-related entries '**/mix.lock', +'**/_build/**', +'**/deps/**', // Essential Haskell-related entries '**/stack.yaml.lock', '**/cabal.project.freeze', +'**/.stack-work/**', +'**/dist-newstyle/**',
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/config/defaultIgnore.ts(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (11)
- GitHub Check: Test (macos-latest, 23.x)
- GitHub Check: Test (macos-latest, 21.x)
- GitHub Check: Test (windows-latest, 23.x)
- GitHub Check: Test (windows-latest, 22.x)
- GitHub Check: Test (windows-latest, 21.x)
- GitHub Check: Test (windows-latest, 20.x)
- GitHub Check: Test (windows-latest, 19.x)
- GitHub Check: Test (windows-latest, 18.x)
- GitHub Check: Test (windows-latest, 18.0.0)
- GitHub Check: Test coverage
- GitHub Check: Cloudflare Pages
🔇 Additional comments (3)
src/config/defaultIgnore.ts (3)
57-63: LGTM! Comprehensive coverage of cache directories.The expansion to include
.rollup.cache,.webpack.cache,.parcel-cache, and.sass-cacheprovides better coverage for common build tool cache directories.
125-130: LGTM! Good organization of Node.js-related entries.The consolidation of package manager lock files under a dedicated "Essential Node.js-related entries" section improves clarity. The addition of
bun.lockbensures future compatibility with the Bun package manager.
Line range hint
1-163: Verify for duplicate patterns.Some patterns might be duplicated across different sections. For example,
vendor/**appears in the "Dependency directories" section and is suggested to be added to language-specific sections.✅ Verification successful
No problematic duplicate patterns found in the ignore list
The patterns that appear similar (like
target/**and**/target/**) are intentionally different to cover both root-level and nested occurrences. Other similar patterns (like variousdistandbuildpatterns) are correctly segregated based on their specific contexts and purposes.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Find potential duplicate patterns in the ignore list cat src/config/defaultIgnore.ts | grep -o "'[^']*'" | sort | uniq -dLength of output: 79
Script:
#!/bin/bash # Extract and analyze patterns from defaultIgnore.ts echo "=== Exact duplicates ===" grep -o "'[^']*'" src/config/defaultIgnore.ts | tr -d "'" | sort | uniq -d echo -e "\n=== Similar patterns (grouped) ===" grep -o "'[^']*'" src/config/defaultIgnore.ts | tr -d "'" | sort | grep -E '(target/|node_modules/|vendor/|build/|dist/|temp/|tmp/|cache|lock)'Length of output: 860
Checklist
npm run testnpm run lint