Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .repopackignore and enhance ignore pattern documentation #13

Merged
merged 2 commits into from
Jul 27, 2024

Conversation

yamadashy
Copy link
Owner

fix: #12
This pull request introduces support for .repopackignore files and improves the documentation for ignore patterns in Repopack.

Key changes:

  • Added support for .repopackignore files
  • Updated the "Ignore Patterns" section in the README
  • Rearrange priority order for ignore patterns

Ignore priority order (from highest to lowest):

  1. Custom patterns ignore.customPatterns
  2. .repopackignore
  3. .gitignore (if ignore.useGitignorePatterns is true)
  4. Default patterns (if ignore.useDefaultPatterns is true)

@massdo
Copy link
Contributor

massdo commented Jul 27, 2024

Hello,

Thank you for your quick and thoughtful response! Your proposed approach sounds perfect and addresses the issue comprehensively.

I do have one small suggestion regarding the naming of the configuration option. Instead of useGitignorePatterns, perhaps useGitignore or useGitignoreFile would be clearer. This can help avoid potential confusion with a setting that might suggest switching from a wildcard format to a regex format.

Best regards,

@yamadashy
Copy link
Owner Author

Thank you for taking a look and for your suggestion! I agree that your proposed option is clearer.
I think we'll go with the simple useGitignore option.

@yamadashy yamadashy force-pushed the feature/repopackignore branch from ef5cab3 to 002c76f Compare July 27, 2024 08:09
@yamadashy
Copy link
Owner Author

I've implemented the changes. Your input has helped improve the feature!
I'm going to merge this pull request now. Thanks again for your contribution to making Repopack better!

@yamadashy yamadashy merged commit 80702fc into main Jul 27, 2024
10 checks passed
@yamadashy yamadashy deleted the feature/repopackignore branch July 29, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Propose .repopackignore file to override .gitignore for repopack bundles
2 participants