-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.0.0-alpha.0] Publishing ES and CJS #218
Conversation
Thank you for updating this! ❤️ I personally feel it makes sense to make breaking changes then bump major version. React.lazy and intersection observer actually look higher priority to me as they are actual perf improvement! |
@kaesonho I think you are the person who knows the viewport and lifecycle/context use case :) I could do most of the build/es module part, and will be good if you could help for the places you are most familiar to. I think we could seclude several alpha release so people could test out and slowing moving to the direction we want. |
Will work on this PR again cause its preventing user to use the new context API cause react can only use one type of context api now. Discussed with Kaeson, we will probably do small alpha release for each features so we won't be blocked by the whole list. |
Issue for multiple context: facebook/react#14005 |
Split into separate small PRs |
LGTM! 💯 🎆 thank you for making this change! |
@redonkulus Do you think the approach of progressively release small version make sense to you? |
@roderickhsiao I'm fine with this approach, makes more sense to do a series of small PR's, instead of one massive one. |
@@ -1,279 +1,303 @@ | |||
// jscs:disable maximumLineLength |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd get rid of Grunt entirely in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
Release Log
Enhancement
Breaking changes
Build
|
Summery
This is the first 3.0.0 alpha PR, tracked in a master issue #224
This PR change to es syntax and publish both cjs and es module.
Enhancement:
Breaking Changes
followLink
@kaesonho @redonkulus How do you think?
Put out the WIP PR to get some early feedback, also if I can get some help will be lovely.