Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What about .tsx extensions? #15

Open
httpete opened this issue Aug 4, 2022 · 2 comments
Open

What about .tsx extensions? #15

httpete opened this issue Aug 4, 2022 · 2 comments

Comments

@httpete
Copy link

httpete commented Aug 4, 2022

We always use tsx extensions, but it won't let me do that? This is a bug.

@yGuy
Copy link
Member

yGuy commented Aug 5, 2022

TSX files are currently not supported, unfortunately. Some would argue that TSX is a bug, because it's not valid JavaScript or TypeScript ;-) , but from the perspective of the migration tool it's a missing feature or limitation, although a relatively important one for many.

That said, to use the "analysis" part of the migration tool, it might work to check the output of tsc against the tool. If you are only migrating from the previous versions, chances are very high that the number of API changes is close to zero and getting a confirmation from the tool is enough, already. Modifying TSX code should be feasible if we use jscodeshift ( facebook/jscodeshift#180 )

@httpete
Copy link
Author

httpete commented Aug 5, 2022

Yes Sebastian, it looks like TypeScript to the rescue, and the type support of yFiles is getting stronger in this release. We can get by - by hand for now since our yFiles footprint is small. But codemods would be great, like Angular ships between releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants