Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dbnary data loading on Windows #17

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

Vuizur
Copy link
Contributor

@Vuizur Vuizur commented Feb 21, 2024

I could build the pl-pl database now, it looked reasonable.

@xxyzz
Copy link
Owner

xxyzz commented Feb 22, 2024

If you could install wget and perl, why not install the compress tools? They use threads and are way faster.

@Vuizur
Copy link
Contributor Author

Vuizur commented Feb 22, 2024

I mostly did not use them because they are not on Winget. I couldn't find the unzip command line programs on chocolatey either.

@xxyzz xxyzz force-pushed the fix-dbnary-on-windows branch from 07eb301 to e8e673f Compare February 22, 2024 09:59
@xxyzz
Copy link
Owner

xxyzz commented Feb 22, 2024

Sorry I removed the winget commands... I expect the users could figure out the dependencies. And I feel it's inappropriate to add commands install nonofficial packages.

@xxyzz xxyzz merged commit fa9ef01 into xxyzz:master Feb 22, 2024
18 checks passed
@Vuizur
Copy link
Contributor Author

Vuizur commented Feb 22, 2024 via email

@xxyzz
Copy link
Owner

xxyzz commented Feb 22, 2024

I think Winget also downloads .exe files from other places: https://github.com/microsoft/winget-pkgs/blob/master/manifests/j/JernejSimoncic/Wget/1.21.4/JernejSimoncic.Wget.installer.yaml

But it doesn't matter... There are too many ways to install packages, so I'll just list the dependencies and let users decide how to install them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants