Split by comma + handle nested parentheses #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only keep the text before the first comma, texts after comma usually are not a complete sentence.
xxyzz
force-pushed
the
split-by-comma
branch
from
172f94b to
12cc2e9
Compare
|
Thanks for your contribution! I changed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the proper version of xxyzz/WordDumb#187
I think it's an improvement. There might be more possible heuristics to apply here.
I additionally found that the current regex did not handle nested parentheses when I stumbled upon some glosses with them in the English Wiktionary.