Skip to content

Artifact for unit tests #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Artifact for unit tests #143

wants to merge 3 commits into from

Conversation

ShreyashKore
Copy link

@ShreyashKore ShreyashKore commented Mar 5, 2025 •
edited
Loading

Tests are removed as they seem unnecessary. Do we need to support the usage of key?

closes #140

xxfast
xxfast reviewed Mar 15, 2025
View reviewed changes
Copy link
Owner

@xxfast xxfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you so much for the PR

Do you think we can name this module kstore-test instead of kstore-testing?

@ShreyashKore
Copy link
Author

Done !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxfast xxfast xxfast left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide an artifact for unit tests
2 participants
@ShreyashKore @xxfast