Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regen examples #405

Merged
merged 1 commit into from
Feb 21, 2024
Merged

regen examples #405

merged 1 commit into from
Feb 21, 2024

Conversation

cdietrich
Copy link
Member

No description provided.

@cdietrich
regen examples
e234197 
Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>
LorenzoBettini
LorenzoBettini reviewed Feb 20, 2024
View reviewed changes
Copy link
Contributor

@LorenzoBettini LorenzoBettini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the domainmodel should have commons logging in the TP as well. I forgot to do that in the xtext repo myself

@cdietrich cdietrich merged commit d415613 into master Feb 21, 2024
30 checks passed
@cdietrich cdietrich deleted the cd-regen-m3 branch February 21, 2024 12:47
@cdietrich
Copy link
Member Author

@LorenzoBettini can you check if we need a follow up?

@LorenzoBettini
Copy link
Contributor

@cdietrich see my comment on the domainmodel's TP

@cdietrich
Copy link
Member Author

So we assume tycho magic will work ??

@LorenzoBettini
Copy link
Contributor

I meant: if we want to be consistent, also the TP of domainmodel should be enhanced with the explicit specification of commons.logging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LorenzoBettini LorenzoBettini LorenzoBettini left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdietrich @LorenzoBettini