Tests for objects/quests xr conditions.

src/engine/lib/constants/story_names.ts

@@ -34,6 +34,7 @@ export const storyNames = {
   jup_b9_spot: "jup_b9_spot",
   pri_a15_door: "pri_a15_door",
   pri_a16: "pri_a16",
+  pri_a16_military_squad: "pri_a16_military_squad",
   pri_a16_spot: "pri_a16_spot",
   pri_a16_sr_sleep: "pri_a16_sr_sleep",
   pri_a16_sr_sleep_id: "pri_a16_sr_sleep_id",

src/engine/scripts/declarations/conditions/object.test.ts

@@ -971,7 +971,26 @@ describe("object conditions implementation", () => {
     );
   });
 
-  it.todo("active_item should check object active item");
+  it("active_item should check object active item", () => {
+    const { actorGameObject } = mockRegisteredActor();
+
+    const first: GameObject = MockGameObject.mock({ section: "test-1" });
+    const second: GameObject = MockGameObject.mock({ section: "test-2" });
+
+    expect(callXrCondition("active_item", actorGameObject, MockGameObject.mock())).toBe(false);
+    expect(
+      callXrCondition("active_item", actorGameObject, MockGameObject.mock(), first.section(), second.section())
+    ).toBe(false);
+
+    jest.spyOn(actorGameObject, "item_in_slot").mockImplementation(() => first);
+
+    expect(
+      callXrCondition("active_item", actorGameObject, MockGameObject.mock(), first.section(), second.section())
+    ).toBe(true);
+
+    expect(callXrCondition("active_item", actorGameObject, MockGameObject.mock(), first.section())).toBe(true);
+    expect(callXrCondition("active_item", actorGameObject, MockGameObject.mock(), second.section())).toBe(false);
+  });
 
   it.todo("check_bloodsucker_state should check bloodsucker state");
 

src/engine/scripts/declarations/conditions/object.ts

@@ -883,12 +883,14 @@ extern("xr_conditions.fighting_dist_le", (actor: GameObject, object: GameObject,
 });
 
 /**
- * todo;
+ * Check if one of provided items is active in slot 3 of actor.
  */
-extern("xr_conditions.active_item", (actor: GameObject, __: GameObject, params: LuaArray<TSection>): boolean => {
-  if (params && params.has(1)) {
-    for (const [, section] of params) {
-      if (actor.item_in_slot(3) !== null && actor.item_in_slot(3)!.section() === section) {
+extern("xr_conditions.active_item", (actor: GameObject, __: GameObject, parameters: Array<TSection>): boolean => {
+  const item: Optional<GameObject> = actor.item_in_slot(3);
+
+  if (item) {
+    for (const [, section] of ipairs(parameters)) {
+      if (item && item.section() === section) {
         return true;
       }
     }

src/engine/scripts/declarations/conditions/quests.test.ts

@@ -1,6 +1,21 @@
-import { beforeAll, describe, it } from "@jest/globals";
+import { beforeAll, beforeEach, describe, expect, it, jest } from "@jest/globals";
+import { level } from "xray16";
 
-import { checkXrCondition } from "@/fixtures/engine";
+import { AnomalyZoneBinder } from "@/engine/core/binders/zones";
+import {
+  registerAnomalyZone,
+  registerObject,
+  registerSimulator,
+  registerStoryLink,
+  registry,
+} from "@/engine/core/database";
+import { disableInfoPortion, giveInfoPortion } from "@/engine/core/utils/info_portion";
+import { infoPortions } from "@/engine/lib/constants/info_portions";
+import { storyNames } from "@/engine/lib/constants/story_names";
+import { GameObject, ServerHumanObject, ServerObject } from "@/engine/lib/types";
+import { zatB29AfTable, zatB29InfopBringTable } from "@/engine/scripts/declarations/dialogs/dialogs_zaton";
+import { callXrCondition, checkXrCondition, mockRegisteredActor, MockSquad, resetRegistry } from "@/fixtures/engine";
+import { MockAlifeHumanStalker, MockAlifeObject, MockGameObject } from "@/fixtures/xray";
 
 describe("quests conditions declaration", () => {
   beforeAll(() => {
@@ -32,35 +47,268 @@ describe("quests conditions implementation", () => {
     require("@/engine/scripts/declarations/conditions/quests");
   });
 
-  it.todo("zat_b29_anomaly_has_af should check anomaly and artefact");
+  beforeEach(() => {
+    resetRegistry();
+  });
+
+  it("zat_b29_anomaly_has_af should check anomaly and artefact", () => {
+    expect(callXrCondition("zat_b29_anomaly_has_af", MockGameObject.mockActor(), MockGameObject.mock())).toBe(false);
+
+    const object: GameObject = MockGameObject.mock();
+    const anomaly: AnomalyZoneBinder = new AnomalyZoneBinder(object);
+    const artefact: ServerObject = MockAlifeObject.mock();
+
+    mockRegisteredActor();
+    registerAnomalyZone(anomaly);
+    registerSimulator();
+
+    expect(
+      callXrCondition(
+        "zat_b29_anomaly_has_af",
+        MockGameObject.mockActor(),
+        MockGameObject.mock(),
+        anomaly.object.name()
+      )
+    ).toBe(false);
+
+    giveInfoPortion(zatB29InfopBringTable.get(23));
+
+    registry.artefacts.ways.set(artefact.id, "test");
+
+    expect(
+      callXrCondition(
+        "zat_b29_anomaly_has_af",
+        MockGameObject.mockActor(),
+        MockGameObject.mock(),
+        anomaly.object.name()
+      )
+    ).toBe(false);
+
+    anomaly.spawnedArtefactsCount = 10;
+
+    expect(
+      callXrCondition(
+        "zat_b29_anomaly_has_af",
+        MockGameObject.mockActor(),
+        MockGameObject.mock(),
+        anomaly.object.name()
+      )
+    ).toBe(false);
+
+    jest.spyOn(artefact, "section_name").mockImplementation(() => zatB29AfTable.get(23));
+
+    expect(
+      callXrCondition(
+        "zat_b29_anomaly_has_af",
+        MockGameObject.mockActor(),
+        MockGameObject.mock(),
+        anomaly.object.name()
+      )
+    ).toBe(true);
+  });
 
   it.todo("jup_b221_who_will_start should check start object");
 
   it.todo("pas_b400_actor_far_forward should check actor state");
 
   it.todo("pas_b400_actor_far_backward should check actor state");
 
-  it.todo("pri_a28_actor_is_far should check actor state");
+  it("pri_a28_actor_is_far should check actor state", () => {
+    expect(() => callXrCondition("pri_a28_actor_is_far", MockGameObject.mockActor(), MockGameObject.mock())).toThrow(
+      "Unexpected actor distance check - no squad existing."
+    );
+
+    const squad: MockSquad = MockSquad.createRegistered();
+    const first: ServerHumanObject = MockAlifeHumanStalker.mock();
+    const second: ServerHumanObject = MockAlifeHumanStalker.mock();
+
+    registerSimulator();
+    registerStoryLink(squad.id, "pri_a16_military_squad");
+
+    expect(callXrCondition("pri_a28_actor_is_far", MockGameObject.mockActor(), MockGameObject.mock())).toBe(true);
+
+    squad.mockAddMember(first);
+    squad.mockAddMember(second);
+
+    jest.spyOn(first.position, "distance_to_sqr").mockImplementation(() => 150 * 150 - 1);
+    jest.spyOn(second.position, "distance_to_sqr").mockImplementation(() => 150 * 150 - 1);
+
+    expect(callXrCondition("pri_a28_actor_is_far", MockGameObject.mockActor(), MockGameObject.mock())).toBe(false);
+
+    jest.spyOn(first.position, "distance_to_sqr").mockImplementation(() => 150 * 150 + 1);
+    jest.spyOn(second.position, "distance_to_sqr").mockImplementation(() => 150 * 150 + 1);
+
+    expect(callXrCondition("pri_a28_actor_is_far", MockGameObject.mockActor(), MockGameObject.mock())).toBe(true);
+  });
 
   it.todo("jup_b25_senya_spawn_condition should check alcoholic spawn condition");
 
-  it.todo("jup_b25_flint_gone_condition should check flint gone condition");
+  it("jup_b25_flint_gone_condition should check flint gone condition", () => {
+    mockRegisteredActor();
+
+    expect(callXrCondition("jup_b25_flint_gone_condition", MockGameObject.mockActor(), MockGameObject.mock())).toBe(
+      false
+    );
+
+    giveInfoPortion(infoPortions.jup_b25_flint_blame_done_to_duty);
+    expect(callXrCondition("jup_b25_flint_gone_condition", MockGameObject.mockActor(), MockGameObject.mock())).toBe(
+      true
+    );
+
+    disableInfoPortion(infoPortions.jup_b25_flint_blame_done_to_duty);
+    giveInfoPortion(infoPortions.jup_b25_flint_blame_done_to_freedom);
+    expect(callXrCondition("jup_b25_flint_gone_condition", MockGameObject.mockActor(), MockGameObject.mock())).toBe(
+      true
+    );
+
+    disableInfoPortion(infoPortions.jup_b25_flint_blame_done_to_freedom);
+    giveInfoPortion(infoPortions.zat_b106_found_soroka_done);
+    expect(callXrCondition("jup_b25_flint_gone_condition", MockGameObject.mockActor(), MockGameObject.mock())).toBe(
+      true
+    );
+
+    disableInfoPortion(infoPortions.zat_b106_found_soroka_done);
+    expect(callXrCondition("jup_b25_flint_gone_condition", MockGameObject.mockActor(), MockGameObject.mock())).toBe(
+      false
+    );
+  });
 
   it.todo("zat_b103_actor_has_needed_food should check actor inventory");
 
   it.todo("zat_b29_rivals_dialog_precond should check dialog condition");
 
-  it.todo("jup_b202_actor_treasure_not_in_steal should check treasure state");
+  it("jup_b202_actor_treasure_not_in_steal should check treasure state", () => {
+    mockRegisteredActor();
+
+    expect(
+      callXrCondition("jup_b202_actor_treasure_not_in_steal", MockGameObject.mockActor(), MockGameObject.mock())
+    ).toBe(true);
+
+    giveInfoPortion(infoPortions.jup_b52_actor_items_can_be_stolen);
+
+    expect(
+      callXrCondition("jup_b202_actor_treasure_not_in_steal", MockGameObject.mockActor(), MockGameObject.mock())
+    ).toBe(false);
 
-  it.todo("jup_b47_npc_online should check npc online state");
+    giveInfoPortion(infoPortions.jup_b202_actor_items_returned);
 
-  it.todo("zat_b7_is_night should check day state");
+    expect(
+      callXrCondition("jup_b202_actor_treasure_not_in_steal", MockGameObject.mockActor(), MockGameObject.mock())
+    ).toBe(true);
+  });
+
+  it("jup_b47_npc_online should check npc online state", () => {
+    expect(callXrCondition("jup_b47_npc_online", MockGameObject.mockActor(), MockGameObject.mock(), "test-sid")).toBe(
+      false
+    );
 
-  it.todo("zat_b7_is_late_attack_time should check day state");
+    const object: GameObject = MockGameObject.mock();
 
-  it.todo("jup_b202_inventory_box_empty should check box state");
+    registerSimulator();
+    registerObject(object);
+    registerStoryLink(object.id(), "test-sid");
 
-  it.todo("jup_b16_is_zone_active should check zone");
+    expect(callXrCondition("jup_b47_npc_online", MockGameObject.mockActor(), MockGameObject.mock(), "test-sid")).toBe(
+      false
+    );
 
-  it.todo("is_jup_a12_mercs_time should check day state");
+    MockAlifeHumanStalker.mock({ id: object.id() });
+
+    expect(callXrCondition("jup_b47_npc_online", MockGameObject.mockActor(), MockGameObject.mock(), "test-sid")).toBe(
+      true
+    );
+  });
+
+  it("zat_b7_is_night should check day state", () => {
+    expect(callXrCondition("zat_b7_is_night", MockGameObject.mockActor(), MockGameObject.mock())).toBe(false);
+
+    const { actorGameObject } = mockRegisteredActor();
+
+    expect(callXrCondition("zat_b7_is_night", actorGameObject, MockGameObject.mock())).toBe(false);
+
+    jest.spyOn(level, "get_time_hours").mockImplementation(() => 23);
+    expect(callXrCondition("zat_b7_is_night", actorGameObject, MockGameObject.mock())).toBe(true);
+
+    jest.spyOn(level, "get_time_hours").mockImplementation(() => 4);
+    expect(callXrCondition("zat_b7_is_night", actorGameObject, MockGameObject.mock())).toBe(true);
+
+    jest.spyOn(level, "get_time_hours").mockImplementation(() => 22);
+    expect(callXrCondition("zat_b7_is_night", actorGameObject, MockGameObject.mock())).toBe(false);
+
+    jest.spyOn(level, "get_time_hours").mockImplementation(() => 5);
+    expect(callXrCondition("zat_b7_is_night", actorGameObject, MockGameObject.mock())).toBe(false);
+  });
+
+  it("zat_b7_is_late_attack_time should check day state", () => {
+    expect(callXrCondition("zat_b7_is_late_attack_time", MockGameObject.mockActor(), MockGameObject.mock())).toBe(
+      false
+    );
+
+    const { actorGameObject } = mockRegisteredActor();
+
+    jest.spyOn(level, "get_time_hours").mockImplementation(() => 23);
+    expect(callXrCondition("zat_b7_is_late_attack_time", actorGameObject, MockGameObject.mock())).toBe(true);
+
+    jest.spyOn(level, "get_time_hours").mockImplementation(() => 8);
+    expect(callXrCondition("zat_b7_is_late_attack_time", actorGameObject, MockGameObject.mock())).toBe(true);
+
+    jest.spyOn(level, "get_time_hours").mockImplementation(() => 22);
+    expect(callXrCondition("zat_b7_is_late_attack_time", actorGameObject, MockGameObject.mock())).toBe(false);
+
+    jest.spyOn(level, "get_time_hours").mockImplementation(() => 10);
+    expect(callXrCondition("zat_b7_is_late_attack_time", actorGameObject, MockGameObject.mock())).toBe(false);
+  });
+
+  it("jup_b202_inventory_box_empty should check box state", () => {
+    expect(() => {
+      callXrCondition("jup_b202_inventory_box_empty", MockGameObject.mockActor(), MockGameObject.mock());
+    }).toThrow();
+
+    const object: GameObject = MockGameObject.mock();
+
+    registerObject(object);
+    registerStoryLink(object.id(), storyNames.jup_b202_actor_treasure);
+
+    jest.spyOn(object, "is_inv_box_empty").mockImplementation(() => true);
+    expect(callXrCondition("jup_b202_inventory_box_empty", MockGameObject.mockActor(), MockGameObject.mock())).toBe(
+      true
+    );
+
+    jest.spyOn(object, "is_inv_box_empty").mockImplementation(() => false);
+    expect(callXrCondition("jup_b202_inventory_box_empty", MockGameObject.mockActor(), MockGameObject.mock())).toBe(
+      false
+    );
+  });
+
+  it("jup_b16_is_zone_active should check zone", () => {
+    expect(callXrCondition("jup_b16_is_zone_active", MockGameObject.mockActor(), MockGameObject.mock())).toBe(false);
+
+    const zone: GameObject = MockGameObject.mock();
+    const { actorGameObject } = mockRegisteredActor();
+
+    expect(callXrCondition("jup_b16_is_zone_active", actorGameObject, zone)).toBe(false);
+
+    giveInfoPortion(zone.name());
+    expect(callXrCondition("jup_b16_is_zone_active", actorGameObject, zone)).toBe(true);
+  });
+
+  it("is_jup_a12_mercs_time should check day state", () => {
+    expect(callXrCondition("is_jup_a12_mercs_time", MockGameObject.mockActor(), MockGameObject.mock())).toBe(false);
+
+    const { actorGameObject } = mockRegisteredActor();
+
+    expect(callXrCondition("is_jup_a12_mercs_time", actorGameObject, MockGameObject.mock())).toBe(false);
+
+    jest.spyOn(level, "get_time_hours").mockImplementation(() => 0);
+    expect(callXrCondition("is_jup_a12_mercs_time", actorGameObject, MockGameObject.mock())).toBe(false);
+
+    jest.spyOn(level, "get_time_hours").mockImplementation(() => 1);
+    expect(callXrCondition("is_jup_a12_mercs_time", actorGameObject, MockGameObject.mock())).toBe(true);
+
+    jest.spyOn(level, "get_time_hours").mockImplementation(() => 4);
+    expect(callXrCondition("is_jup_a12_mercs_time", actorGameObject, MockGameObject.mock())).toBe(true);
+
+    jest.spyOn(level, "get_time_hours").mockImplementation(() => 5);
+    expect(callXrCondition("is_jup_a12_mercs_time", actorGameObject, MockGameObject.mock())).toBe(false);
+  });
 });