Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Copy favorite mounts setup from journal #83

Open
Thex-PiedDroit opened this issue Jan 25, 2022 · 3 comments
Open

[Feature request] Copy favorite mounts setup from journal #83

Thex-PiedDroit opened this issue Jan 25, 2022 · 3 comments

Comments

@Thex-PiedDroit
Copy link

Hi there!

I just installed the addon as it seems really cool, but, having a collection of almost 400 mounts, with a good 100 of them setup as favorite, it's very painful having to go through the list of mounts to disable them one by one.

A button in the settings allowing users to copy the journal's current setup would be great and would help a lot with initial setup.
This function should make this a trivial feature, i believe: https://wowpedia.fandom.com/wiki/API_C_MountJournal.GetIsFavorite

Thank you, have a wonderful day!

@Thex-PiedDroit
Copy link
Author

Edit: I had some time and ended up making it myself, and made a pull request for it:
#84

@mbattersby
Copy link
Collaborator

I think what I'd like to do with this is have some kind of "first use" popup to tell people they have to set a keybind or create a macro and also present an option to import the favorites like this.

@mbattersby
Copy link
Collaborator

A minor complexity (while I think to note it) is, how to deal with priorities for non-journal mounts (flight forms, items, etc) when initializing, since they obviously aren't in C_MountJournal.GetIsFavorite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants