Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A search box for rules? #256

Open
mbattersby opened this issue Jul 13, 2024 · 2 comments
Open

A search box for rules? #256

mbattersby opened this issue Jul 13, 2024 · 2 comments
Assignees

Comments

@mbattersby
Copy link
Collaborator

From the curseforge comments:

Can we please get a search function to filter our rules? I have a lot of rules setup and trying to find certain ones is a real pain if I can't keyword search the list. Thanks!

How would this work? What would you type and what would it find?

@mbattersby mbattersby self-assigned this Jul 13, 2024
@Sahasrahla
Copy link

This wasn't my suggestion, but I can see a use-case for it. I'm currently sitting at 55 rules. I have rules for each Class, each Race, a couple of Professions and a handful of Class Specs. It would be neat if I could search the word "Class" and it would filter the list down to only the rules containing a "Class : something" condition; similarly with "Race". Perhaps I search "Mage" and it returns my "Class : Mage" as well as my "Specialization : Mage : Arcane", "Specialization : Mage : Fire", etc. If I search "Profession", it returns my rules containing "Advanced : profession:something"

This would allow me to quickly find a rule if I need to edit it, or allow me to confirm I didn't miss any classes/races, etc. when creating all the rules.

@mbattersby
Copy link
Collaborator Author

mbattersby commented Feb 14, 2025

I still think this is a good idea, and the probable mechanism is to have the rule parser annotate the object with a keywords list that munges a heap of attributes together.

The keywords would probably include all of the condition tags and localized texts, the raw condition args, the action tag and maybe localized texts, and the action args plus all the mount attributes if the arg is a single mount.

Given how slow string.find is, I suspect for performance they should all be jammed into one long string so it's only a single call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants