Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide an explicit and configurable way to enable/disable certificate checking #71

Open
juanvalino opened this issue Dec 1, 2023 · 1 comment
Open

Provide an explicit and configurable way to enable/disable certificate checking #71

juanvalino opened this issue Dec 1, 2023 · 1 comment

Comments

@juanvalino
Copy link

We need some way to enable/disable certificate checking. Currently the library uses the top-level wrap_socket function, which got removed in Python 3.12; that one never did certificate validation. However, using default context's wrap_socket always did certificate validation (since Python 2.7.x for some x < 20 IIRC).
@juanvalino juanvalino mentioned this issue Dec 1, 2023
Open
1 task
@gdt
Copy link

gdt commented Nov 22, 2024

Agreed, and I think it should default to enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gdt @juanvalino