Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rows statuses of "hidden" and "disabled" after adding all rows #370

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

su23
Copy link

@su23 su23 commented Apr 2, 2016

If you have some complex dependency between rows (for example in row A visibility is depended on the value of row B which is located below row A) then you need to have an access to this row (which may not exists in the UI at that moment). Thus, the "visibility" or "disable" status of row A is not right.

In my change I split the logic of row adding and updating phases. Thus, in the first step we add all rows to the section and only after that evaluate "hidden" and "disable" rules for each added row.

@mats-claassen
Copy link
Member

Hi @su23 I think this does not fix the real problem. Suppose the following case:
You add two rows that depend on a third. And after that you add the third in a new call.
In this case you would not reevaluate the previous rows. We have to find a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants