Skip to content

Commit

Permalink
Cleanup and add more inspection to hawktracer
Browse files Browse the repository at this point in the history
  • Loading branch information
shssoichiro committed Apr 17, 2023
1 parent 0c246c2 commit 80d0ff2
Show file tree
Hide file tree
Showing 20 changed files with 241 additions and 204 deletions.
1 change: 1 addition & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ desync_finder = ["backtrace"]
bench = []
check_asm = []
capi = ["scan_fmt"]
tracing = ["rust_hawktracer/profiling_enabled"]
tracing = ["rust_hawktracer/profiling_enabled", "rust_hawktracer/pkg_config"]
scenechange = []
serialize = ["serde", "toml", "v_frame/serialize", "serde-big-array"]
wasm = ["wasm-bindgen"]
Expand Down
4 changes: 4 additions & 0 deletions doc/PROFILING.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@ We use [rust\_hawktracer](https://github.com/AlexEne/rust_hawktracer) to
measure specific codepath timings. Building `--features=tracing` enables it.
Use the standard [hawktrace-convert](https://hawktracer.org) to produce graphs.

Currently there are issues where rust_hawktracer fails to build, as a result
we have set it to use the system hawktracer library. On Arch Linux this may
be installed from the AUR package hawktracer-git.

## Codegen Inspection

### Assembly
Expand Down
4 changes: 2 additions & 2 deletions src/activity.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ pub struct ActivityMask {
}

impl ActivityMask {
#[hawktracer(activity_mask_from_plane)]
#[hawktracer(ActivityMask_from_plane)]
pub fn from_plane<T: Pixel>(luma_plane: &Plane<T>) -> ActivityMask {
let PlaneConfig { width, height, .. } = luma_plane.cfg;

Expand Down Expand Up @@ -55,7 +55,7 @@ impl ActivityMask {
ActivityMask { variances: variances.into_boxed_slice() }
}

#[hawktracer(activity_mask_fill_scales)]
#[hawktracer(ActivityMask_fill_scales)]
pub fn fill_scales(
&self, bit_depth: usize, activity_scales: &mut Box<[DistortionScale]>,
) {
Expand Down
Loading

0 comments on commit 80d0ff2

Please sign in to comment.