From 3542ae8e7d2c0aec2f2096dab10090e0cce3e413 Mon Sep 17 00:00:00 2001 From: Martijn van Beurden Date: Mon, 27 Jan 2025 09:22:55 +0100 Subject: [PATCH] Upgrade an assert to an error --- src/flac/decode.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/flac/decode.c b/src/flac/decode.c index 12942f062f..71e1cdcfaa 100644 --- a/src/flac/decode.c +++ b/src/flac/decode.c @@ -1668,7 +1668,11 @@ void metadata_callback(const FLAC__StreamDecoder *decoder, const FLAC__StreamMet FLAC__ASSERT(decoder_session->skip_specification->value.samples >= 0); FLAC__ASSERT(decoder_session->until_specification->value.samples >= 0); - FLAC__ASSERT((FLAC__uint64)decoder_session->until_specification->value.samples <= decoder_session->total_samples); + if((FLAC__uint64)decoder_session->until_specification->value.samples > decoder_session->total_samples) { + flac__utils_printf(stderr, 1, "%s: ERROR specified cuepoints exceed length of file\n", decoder_session->inbasefilename); + decoder_session->abort_flag = true; + return; + } FLAC__ASSERT(decoder_session->skip_specification->value.samples <= decoder_session->until_specification->value.samples); decoder_session->total_samples = decoder_session->until_specification->value.samples - decoder_session->skip_specification->value.samples;