Replies: 6 comments 1 reply
-
This is fantastic - thank you for this contribution! I will add these translations to the project and credit you for them. |
Beta Was this translation helpful? Give feedback.
-
Hi, I am working on some revisions of the translations for Dutch, because under php 8.2 some break the PHP-code because of the apostrofes (I tested the translations on 8.0 because I could not run 8.2 due to GD not functioning at that time, which does function now). PHP 8.2 is quite unforgivable with apostrofes and I have seen in other languages too, including English, that some functionalities don't work as expected because these files have apostrofes too and as I want to learn more about Chyrp Lite I am giving this some extra attention at the moment. One thing that I can say for sure now is that the .pot-files in the themes contain the value "F Y" to be translated, but do not do that, it will break up some dates. This value shouldn't be translatable, it's the date-format that PHP uses and if you want that to be adjustable, it should be under settings instead of a translatable value. So a version 2 of the Dutch translations will come and I will do some more tests on other languages too which contain the apostrofe (maybe I can use ' or ' for that or else just get rid of the apostrofes in the translations completely). Will come back on this later! |
Beta Was this translation helpful? Give feedback.
-
Don’t worry about the apostrophes in translations - I noticed an issue with some of them in the JavaScript code Chyrp Lite generates and I fixed the issue, here and here. If you see any other occurrences just let me know and I will fix them. I’ll look into the “F Y” issue. |
Beta Was this translation helpful? Give feedback.
-
Okay thanks, I will just review the Dutch translations which will be quite easy to do since I already have the .po files and in the meanwhile look for more instances of the apostrophe in the English texts. I have seen some more issues, but have to set the translations right first before I can be sure, will come back on this with all my findings! |
Beta Was this translation helpful? Give feedback.
-
What did I do? I did a search in all locale-folders (on .po and .pot files) for apostrophes, there were many and not only in the English files but most of them in Italian and some in German. I used notepad++ to replace all instances of ' with ` in .pot and .po files (not .mo because that will corrupt the file) After the replacements I opened all Non-English .po-files (Except Arabic, Korean and Chinese) who now contain the new ` character and saved them again which creates all new .mo files, then I uploaded it all and tested the changes, looks like everything is working perfectly with all extensions activated except the two conflicting ones. If you want me to try the same with Arabic, Korean and Chinese please do say so, if it works it might then be that the "addslashes-function" isn't necessary anymore for apostrophes, which might improve performance a liitle. I also translated the Readme which I forgot the last time and in the future I might translate Chyrp Lite to French and Portuguese too and complete the German translations, I speak 5 languages. These were all the apostrophes in English .pot files (they are replaced by ` in the zipfile): admin\locale\en_US\LC_MESSAGES\admin.pot (2 x) feathers\link\locale\en_US\LC_MESSAGES\link.pot (1 x) feathers\photo\locale\en_US\LC_MESSAGES\photo.pot (1 x) feathers\quote\locale\en_US\LC_MESSAGES\quote.pot (1 x) feathers\text\locale\en_US\LC_MESSAGES\text.pot (1 x) includes\locale\en_US\LC_MESSAGES\chyrp.pot (3 x) modules\comments\locale\en_US\LC_MESSAGES\comments.pot (3 x) modules\recaptchav2\locale\en_US\LC_MESSAGES\recaptchav2.pot (5 x) themes\blossom\locale\en_US\LC_MESSAGES\blossom.pot (7 x) themes\sparrow\locale\en_US\LC_MESSAGES\sparrow.pot (7 x) themes\topaz\locale\en_US\LC_MESSAGES\topaz.pot (7 x) themes\umbra\locale\en_US\LC_MESSAGES\umbra.pot (7 x) themes\virgula\locale\en_US\LC_MESSAGES\virgula.pot (6 x) |
Beta Was this translation helpful? Give feedback.
-
Hello there,
This definitely isn't needed - I have these translations functioning without issues and so do other users. Let's take a step back and try to debug the problems you are experiencing. I don't want to grammatically mangle text to work around a problem that can be fixed in a more elegant way. My advice is for you to download the "develop" branch of Chyrp Lite and upgrade your installation to this; it contains all the most recent changes I have made, including the addition of your translations and the fixes I made in response to the problems your translations revealed in the codebase. The next thing to do is enable DEBUG mode, which will put Chyrp Lite in a stricter mode and report more information when problems occur.
PHP's
"F Y" is a time-formatting code. This can be translated but it usually won't be necessary, because Chyrp Lite tries to use PHP functions that already output the text in the correct language. If you do want to change the way time is displayed, perhaps because the English format I've chosen looks weird in Dutch, you must use the the formatting codes understood by PHP's
Fantastic, thank you! A complete German translation has been on my wish list for some time - and all additional languages are gratefully received. |
Beta Was this translation helpful? Give feedback.
-
I have translated Chyrp Lite to Dutch, including the four not pre-installed mods.
I have a map with the exact structure of Chyrp Lite, but only containing the locales inside the right maps, it's a ZIP.
I tried with a pull request (i believe that's the thing to do) but it was denied, so I try it here.
See attachment.
locales_nl_NL.zip
Beta Was this translation helpful? Give feedback.
All reactions