fixup! base: BiometricScheduler: Cancel operation if not idle #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Avoid IllegalStateException after merge 12.1.0_r8 06-10 06:36:20.380 1124 1124 E AndroidRuntime: *** FATAL EXCEPTION IN SYSTEM PROCESS: main 06-10 06:36:20.380 1124 1124 E AndroidRuntime: java.lang.IllegalStateException: cancel: illegal state= 5 06-10 06:36:20.380 1124 1124 E AndroidRuntime: at com.android.server.biometrics.sensors.BiometricSchedulerOperation.checkNotInState(BiometricSchedulerOperation.java:403) 06-10 06:36:20.380 1124 1124 E AndroidRuntime: at com.android.server.biometrics.sensors.BiometricSchedulerOperation.cancel(BiometricSchedulerOperation.java:245) 06-10 06:36:20.380 1124 1124 E AndroidRuntime: at com.android.server.biometrics.sensors.BiometricScheduler.startNextOperationIfIdle(BiometricScheduler.java:268) 06-10 06:36:20.380 1124 1124 E AndroidRuntime: at com.android.server.biometrics.sensors.BiometricScheduler.scheduleClientMonitor(BiometricScheduler.java:407) 06-10 06:36:20.380 1124 1124 E AndroidRuntime: at com.android.server.biometrics.sensors.fingerprint.hidl.Fingerprint21.scheduleUpdateActiveUserWithoutHandler(Fingerprint21.java:495) 06-10 06:36:20.380 1124 1124 E AndroidRuntime: at com.android.server.biometrics.sensors.fingerprint.hidl.Fingerprint21.scheduleUpdateActiveUserWithoutHandler(Fingerprint21.java:475) 06-10 06:36:20.380 1124 1124 E AndroidRuntime: at com.android.server.biometrics.sensors.fingerprint.hidl.Fingerprint21.lambda$scheduleInternalCleanup$14$Fingerprint21(Fingerprint21.java:704) 06-10 06:36:20.380 1124 1124 E AndroidRuntime: at com.android.server.biometrics.sensors.fingerprint.hidl.Fingerprint21$$ExternalSyntheticLambda12.run(Unknown Source:6) 06-10 06:36:20.380 1124 1124 E AndroidRuntime: at android.os.Handler.handleCallback(Handler.java:938) 06-10 06:36:20.380 1124 1124 E AndroidRuntime: at android.os.Handler.dispatchMessage(Handler.java:99) 06-10 06:36:20.380 1124 1124 E AndroidRuntime: at android.os.Looper.loopOnce(Looper.java:201) 06-10 06:36:20.380 1124 1124 E AndroidRuntime: at android.os.Looper.loop(Looper.java:288) 06-10 06:36:20.380 1124 1124 E AndroidRuntime: at com.android.server.SystemServer.run(SystemServer.java:904) 06-10 06:36:20.380 1124 1124 E AndroidRuntime: at com.android.server.SystemServer.main(SystemServer.java:611) 06-10 06:36:20.380 1124 1124 E AndroidRuntime: at java.lang.reflect.Method.invoke(Native Method) 06-10 06:36:20.380 1124 1124 E AndroidRuntime: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:550) 06-10 06:36:20.380 1124 1124 E AndroidRuntime: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:981) Change-Id: Icb29b4c5aea1fe4882b64b7ba61070e9cce3f63b
xyzuan
pushed a commit
that referenced
this pull request
Aug 28, 2022
be sure the bitmap is mutable before setting it to the Canvas 12-23 19:39:14.631 21188 22105 E AndroidRuntime: FATAL EXCEPTION: AsyncTask #20 12-23 19:39:14.631 21188 22105 E AndroidRuntime: Process: com.android.systemui, PID: 21188 12-23 19:39:14.631 21188 22105 E AndroidRuntime: java.lang.RuntimeException: An error occurred while executing doInBackground() 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at android.os.AsyncTask$4.done(AsyncTask.java:399) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:383) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at java.util.concurrent.FutureTask.setException(FutureTask.java:252) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at java.util.concurrent.FutureTask.run(FutureTask.java:271) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:289) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at java.lang.Thread.run(Thread.java:919) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: Caused by: java.lang.IllegalStateException: Immutable bitmap passed to Canvas constructor 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at android.graphics.Canvas.<init>(Canvas.java:117) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at com.android.systemui.statusbar.MediaArtworkProcessor.processArtwork(MediaArtworkProcessor.kt:87) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at com.android.systemui.statusbar.NotificationMediaManager.processArtwork(NotificationMediaManager.java:708) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at com.android.systemui.statusbar.NotificationMediaManager.access$600(NotificationMediaManager.java:94) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at com.android.systemui.statusbar.NotificationMediaManager$ProcessArtworkTask.doInBackground(NotificationMediaManager.java:750) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at com.android.systemui.statusbar.NotificationMediaManager$ProcessArtworkTask.doInBackground(NotificationMediaManager.java:731) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at android.os.AsyncTask$3.call(AsyncTask.java:378) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at java.util.concurrent.FutureTask.run(FutureTask.java:266) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: ... 4 more Signed-off-by: Arghya Chanda <arghyac35@gmail.com> Change-Id: I229151a18f7cebc4770d8987eaa0e492e8937de8 Signed-off-by: Arghya Chanda <arghyac35@gmail.com> Signed-off-by: SagarMakhar <sagarmakhar@gmail.com> Signed-off-by: Sagarrokade006 <sagarrokade006@gmail.com>
xyzuan
pushed a commit
that referenced
this pull request
Aug 28, 2022
be sure the bitmap is mutable before setting it to the Canvas 12-23 19:39:14.631 21188 22105 E AndroidRuntime: FATAL EXCEPTION: AsyncTask #20 12-23 19:39:14.631 21188 22105 E AndroidRuntime: Process: com.android.systemui, PID: 21188 12-23 19:39:14.631 21188 22105 E AndroidRuntime: java.lang.RuntimeException: An error occurred while executing doInBackground() 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at android.os.AsyncTask$4.done(AsyncTask.java:399) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:383) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at java.util.concurrent.FutureTask.setException(FutureTask.java:252) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at java.util.concurrent.FutureTask.run(FutureTask.java:271) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:289) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at java.lang.Thread.run(Thread.java:919) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: Caused by: java.lang.IllegalStateException: Immutable bitmap passed to Canvas constructor 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at android.graphics.Canvas.<init>(Canvas.java:117) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at com.android.systemui.statusbar.MediaArtworkProcessor.processArtwork(MediaArtworkProcessor.kt:87) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at com.android.systemui.statusbar.NotificationMediaManager.processArtwork(NotificationMediaManager.java:708) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at com.android.systemui.statusbar.NotificationMediaManager.access$600(NotificationMediaManager.java:94) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at com.android.systemui.statusbar.NotificationMediaManager$ProcessArtworkTask.doInBackground(NotificationMediaManager.java:750) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at com.android.systemui.statusbar.NotificationMediaManager$ProcessArtworkTask.doInBackground(NotificationMediaManager.java:731) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at android.os.AsyncTask$3.call(AsyncTask.java:378) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: at java.util.concurrent.FutureTask.run(FutureTask.java:266) 12-23 19:39:14.631 21188 22105 E AndroidRuntime: ... 4 more Signed-off-by: Arghya Chanda <arghyac35@gmail.com> Change-Id: I229151a18f7cebc4770d8987eaa0e492e8937de8 Signed-off-by: Arghya Chanda <arghyac35@gmail.com> Signed-off-by: SagarMakhar <sagarmakhar@gmail.com> Signed-off-by: Sagarrokade006 <sagarrokade006@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
06-10 06:36:20.380 1124 1124 E AndroidRuntime: *** FATAL EXCEPTION IN SYSTEM PROCESS: main
06-10 06:36:20.380 1124 1124 E AndroidRuntime: java.lang.IllegalStateException: cancel: illegal state= 5
06-10 06:36:20.380 1124 1124 E AndroidRuntime: at com.android.server.biometrics.sensors.BiometricSchedulerOperation.checkNotInState(BiometricSchedulerOperation.java:403)
06-10 06:36:20.380 1124 1124 E AndroidRuntime: at com.android.server.biometrics.sensors.BiometricSchedulerOperation.cancel(BiometricSchedulerOperation.java:245)
06-10 06:36:20.380 1124 1124 E AndroidRuntime: at com.android.server.biometrics.sensors.BiometricScheduler.startNextOperationIfIdle(BiometricScheduler.java:268)
06-10 06:36:20.380 1124 1124 E AndroidRuntime: at com.android.server.biometrics.sensors.BiometricScheduler.scheduleClientMonitor(BiometricScheduler.java:407)
06-10 06:36:20.380 1124 1124 E AndroidRuntime: at com.android.server.biometrics.sensors.fingerprint.hidl.Fingerprint21.scheduleUpdateActiveUserWithoutHandler(Fingerprint21.java:495)
06-10 06:36:20.380 1124 1124 E AndroidRuntime: at com.android.server.biometrics.sensors.fingerprint.hidl.Fingerprint21.scheduleUpdateActiveUserWithoutHandler(Fingerprint21.java:475)
06-10 06:36:20.380 1124 1124 E AndroidRuntime: at com.android.server.biometrics.sensors.fingerprint.hidl.Fingerprint21.lambda$scheduleInternalCleanup$14$Fingerprint21(Fingerprint21.java:704)
06-10 06:36:20.380 1124 1124 E AndroidRuntime: at com.android.server.biometrics.sensors.fingerprint.hidl.Fingerprint21$$ExternalSyntheticLambda12.run(Unknown Source:6)
06-10 06:36:20.380 1124 1124 E AndroidRuntime: at android.os.Handler.handleCallback(Handler.java:938)
06-10 06:36:20.380 1124 1124 E AndroidRuntime: at android.os.Handler.dispatchMessage(Handler.java:99)
06-10 06:36:20.380 1124 1124 E AndroidRuntime: at android.os.Looper.loopOnce(Looper.java:201)
06-10 06:36:20.380 1124 1124 E AndroidRuntime: at android.os.Looper.loop(Looper.java:288)
06-10 06:36:20.380 1124 1124 E AndroidRuntime: at com.android.server.SystemServer.run(SystemServer.java:904)
06-10 06:36:20.380 1124 1124 E AndroidRuntime: at com.android.server.SystemServer.main(SystemServer.java:611)
06-10 06:36:20.380 1124 1124 E AndroidRuntime: at java.lang.reflect.Method.invoke(Native Method)
06-10 06:36:20.380 1124 1124 E AndroidRuntime: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:550)
06-10 06:36:20.380 1124 1124 E AndroidRuntime: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:981)
Change-Id: Icb29b4c5aea1fe4882b64b7ba61070e9cce3f63b