You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Scanning the License.rtf file for text matching the agreement as is done here seemed a bit fragile - and I found that there's an actual plist containing two pieces of info at /Applications/Xcode.app/Contents/Resources/LicenseInfo. For example, from the Xcode 7.2 beta:
Also, if com.apple.dt.Xcode is actually a standard Mac preference, it's better to use defaults to set the prefs rather than writing directly to the plist storage to avoid caching issues with cfprefsd.
Filing this to point out the issue, but I can work on a PR for this.
The text was updated successfully, but these errors were encountered:
Just to note that when I last checked what the DVT framework was doing for handling this, it looked like they're just reading the /L/P/com.apple.dt.Xcode.plist directly, not using Preferences/defaults.
Scanning the License.rtf file for text matching the agreement as is done here seemed a bit fragile - and I found that there's an actual plist containing two pieces of info at
/Applications/Xcode.app/Contents/Resources/LicenseInfo
. For example, from the Xcode 7.2 beta:This allows us to more easily grab the agreement number, and know whether it's general release or beta. (
licenseType
will be eitherBeta
orGM
).Knowing whether it's general release or Beta is important because there are actually two other keys that can be set in
com.apple.dt.Xcode
:Also, if com.apple.dt.Xcode is actually a standard Mac preference, it's better to use
defaults
to set the prefs rather than writing directly to the plist storage to avoid caching issues withcfprefsd
.Filing this to point out the issue, but I can work on a PR for this.
The text was updated successfully, but these errors were encountered: