Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update langinfo.xml - (Irish language not working) #526

Open
wants to merge 1 commit into
base: omega
Choose a base branch
from

Conversation

aindriu80
Copy link

Updated langinfo, the main change is changing from ga_IE to simply just ga.

I also added a few regions.

Description

Main change is changing locale from ga_IE to just ga, added some more regions into the file.

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practice but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

Updated langinfo, main change is changing from ga_IE to just ga.
@romanvm
Copy link
Collaborator

romanvm commented Feb 20, 2025

Maybe you should combine this PR with your other PR about changes in addon.xml? No need to open separate PRs for each change, you can just update your source branch from which a PR was opened. I don't know much about langinfo.xml, but when I tried the version that is currently in the Kodi repo but with addon_id fixed, it worked for me, at least language was swiched to what looked like Irish to me :) (yes, I visited Dublin around 1.5 years ago).

@aindriu80
Copy link
Author

aindriu80 commented Feb 20, 2025

Maybe you should combine this PR with your other PR about changes in addon.xml? No need to open separate PRs for each change, you can just update your source branch from which a PR was opened. I don't know much about langinfo.xml, but when I tried the version that is currently in the Kodi repo but with addon_id fixed, it worked for me, at least language was swiched to what looked like Irish to me :) (yes, I visited Dublin around 1.5 years ago).

hi @romanvm, that's great to hear!!

About the PR's I had a lot of issues with Pull Requests on Kodi - usually I make a fork and clone the fork locally, however this repo is huge, and I'm actually on a metered connection at the moment. I was working on GitHub workspaces, but it ended up making individual branches and I could never get changes merged to another branch >< and hence all the PR's and deleted PRs.

I will get the addon_id item sorted now... go raibh míle maith agat :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants