Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coverage #93

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Fix coverage #93

merged 3 commits into from
Dec 2, 2024

Conversation

exekias
Copy link
Member

@exekias exekias commented Dec 2, 2024 •
edited
Loading

root package def is the problem

image

@exekias
Fix coverage
915063b 
testing, I believe the root package def is the problem
@exekias
test
b23595e
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/xataio/pgstream/internal/postgres 0.51% (-1.74%) 👎
Coverage by file

Changed unit test files

  • github.com/xataio/pgstream/internal/postgres/pg_test.go

@exekias
Revert "test"
81ddf01 
This reverts commit b23595e.
@exekias exekias requested a review from eminano December 2, 2024 10:34
@exekias exekias merged commit 17420e7 into main Dec 2, 2024
6 checks passed
@exekias exekias deleted the coverage branch December 2, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eminano eminano eminano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@exekias @eminano