Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow providing replication slot on the CLI #91

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

eminano
Copy link
Collaborator

@eminano eminano commented Dec 2, 2024

The pgstream library already provides the ability to override the replication slot name. This PR adds the plumbing to allow setting it from the CLI.

@eminano eminano force-pushed the allow-to-provide-replication-slot-name-on-cli branch from 0dda482 to c30bbf6 Compare December 2, 2024 09:59
Copy link

github-actions bot commented Dec 2, 2024

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
pgstream/cmd 0.00% (ø)
pgstream/internal/postgres 0.00% (ø)
pgstream/pkg/stream 0.00% (ø)
pgstream/pkg/stream/integration 0.00% (ø)
pgstream/pkg/wal/replication/postgres 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
pgstream/cmd/config.go 0.00% (ø) 0 0 0
pgstream/cmd/init_cmd.go 0.00% (ø) 0 0 0
pgstream/cmd/root_cmd.go 0.00% (ø) 0 0 0
pgstream/internal/postgres/pg_replication_conn.go 0.00% (ø) 0 0 0
pgstream/pkg/stream/stream_init.go 0.00% (ø) 0 0 0
pgstream/pkg/wal/replication/postgres/pg_replication_handler.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • pgstream/pkg/stream/integration/setup_test.go

@eminano eminano requested a review from exekias December 2, 2024 10:01
@eminano eminano merged commit 9186e3e into main Dec 2, 2024
6 checks passed
@eminano eminano deleted the allow-to-provide-replication-slot-name-on-cli branch December 2, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants