Reinforce kafka msg size guards #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
approved these changes
Nov 18, 2024
| if len(walDataBytes) > int(w.maxBatchBytes) { | ||
| // check if walEventBytes is larger than 95% of the Kafka accepted max | ||
| // message size to allow for some buffer for the rest of the message | ||
| if len(walDataBytes) > int(0.95*float64(w.maxBatchBytes)) { |
There was a problem hiding this comment.
this is probably good enough, although it can be a lot of buffer for high max bytes settings, I wonder if there is a predictable payload size math (ie 100bytes padding)
There was a problem hiding this comment.
I'll have a think/look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there's a guard in place to make sure there are no messages sent to kafka that go over the limit in size. However, the check is only accounting for the serialised bytes of the value in the message, but not for the rest of the message (headers, metadata...). This PR updates the size check to ensure we leave some buffer to account for those extra parts of the message, discarding the message and logging it as data loss if the value is more than 95% of the limit.
An error log is added to identify when the send thread stops unexpectedly due to kafka errors.