Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support int32 as id column #109

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Support int32 as id column #109

merged 1 commit into from
Jan 17, 2025

Conversation

agedemenli
Copy link
Contributor

Support int32 as id column for seach

@agedemenli agedemenli force-pushed the support-int32-id-col branch from 5bb9a27 to 15fdd99 Compare January 16, 2025 17:14
@agedemenli agedemenli force-pushed the support-int32-id-col branch from 15fdd99 to c9b3faf Compare January 16, 2025 17:25
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/xataio/pgstream/pkg/wal/processor/search 85.87% (+0.04%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/xataio/pgstream/pkg/wal/processor/search/search_adapter.go 98.39% (+0.01%) 124 (+1) 122 (+1) 2 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/xataio/pgstream/pkg/wal/processor/search/search_adapter_test.go

@agedemenli agedemenli requested a review from eminano January 17, 2025 07:23
@eminano eminano linked an issue Jan 17, 2025 that may be closed by this pull request
@agedemenli agedemenli merged commit d45ff2b into main Jan 17, 2025
6 checks passed
@agedemenli agedemenli deleted the support-int32-id-col branch January 17, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support int32 id columns on search
2 participants