Merge pull request #92 from xataio/replace-period-replication-slot-name

Replace period on replication slot name

internal/postgres/pg_replication_conn.go

@@ -6,6 +6,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"strings"
 	"time"
 
 	"github.com/jackc/pglogrepl"
@@ -121,6 +122,9 @@ func (c *ReplicationConn) Close(ctx context.Context) error {
 }
 
 func DefaultReplicationSlotName(dbName string) string {
+	// sanitise the dbName before creating the replication slot name to ensure
+	// the name does not contain invalid characters.
+	dbName = strings.ReplaceAll(dbName, ".", "_")
 	return "pgstream_" + dbName + "_slot"
 }
 

internal/postgres/pg_test.go

@@ -0,0 +1,41 @@
+// SPDX-License-Identifier: Apache-2.0
+
+package postgres
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+func Test_DefaultReplicationSlotName(t *testing.T) {
+	t.Parallel()
+
+	tests := []struct {
+		name         string
+		wantSlotName string
+	}{
+		{
+			name:         "example",
+			wantSlotName: "pgstream_example_slot",
+		},
+		{
+			name:         "example.com",
+			wantSlotName: "pgstream_example_com_slot",
+		},
+		{
+			name:         "example.test.com",
+			wantSlotName: "pgstream_example_test_com_slot",
+		},
+	}
+
+	for _, tc := range tests {
+		tc := tc
+		t.Run(tc.name, func(t *testing.T) {
+			t.Parallel()
+
+			slotName := DefaultReplicationSlotName(tc.name)
+			require.Equal(t, tc.wantSlotName, slotName)
+		})
+	}
+}