[RGent] Add name and namespace to the codechanges struct.

[mandel-macaque]

We add the name and a collection with the namespaces that contains the type. This way we do not need to query the symbol when generating code and we can simply use the data in the structure.

[Copilot]

Copilot reviewed 5 out of 9 changed files in this pull request and generated 3 comments.

Files not reviewed (4)

• src/rgen/Microsoft.Macios.Generator/ListComparer.cs: Evaluated as low risk
• tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/CodeChangesEqualityComparerTests.cs: Evaluated as low risk
• tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/ClassCodeChangesTests.cs: Evaluated as low risk
• src/rgen/Microsoft.Macios.Generator/DataModel/CodeChangesEqualityComparer.cs: Evaluated as low risk

Comments suppressed due to low confidence (2)

src/rgen/Microsoft.Macios.Generator/DataModel/CodeChanges.cs:281

• Add a check to ensure that the Namespace property is not empty before appending it to the StringBuilder.

sb.Append ($"BindingType: {BindingType}, Name: {Name}, Namespace: [");

src/rgen/Microsoft.Macios.Generator/DataModel/CodeChanges.cs:180

• [nitpick] Consider renaming the @namespace parameter to namespaceArray to make the code more readable and less confusing.

internal CodeChanges (BindingType bindingType, string name, ImmutableArray<string> @namespace, string fullyQualifiedSymbol)

[mandel-macaque]

/azp run xamarin-macios-pr

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[github-actions]

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

[mandel-macaque]

/azp run xamarin-macios-pr

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[vs-mobiletools-engineering-service2]

✅ [CI Build] Build passed (Build packages) ✅

Pipeline on Agent
Hash: c86dcc9288847fe9827b97f4810132aa7efb27e3 [PR build]

[vs-mobiletools-engineering-service2]

✅ [CI Build] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: c86dcc9288847fe9827b97f4810132aa7efb27e3 [PR build]

[vs-mobiletools-engineering-service2]

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: c86dcc9288847fe9827b97f4810132aa7efb27e3 [PR build]

[vs-mobiletools-engineering-service2]

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: c86dcc9288847fe9827b97f4810132aa7efb27e3 [PR build]

[vs-mobiletools-engineering-service2]

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: c86dcc9288847fe9827b97f4810132aa7efb27e3 [PR build]

[vs-mobiletools-engineering-service2]

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: c86dcc9288847fe9827b97f4810132aa7efb27e3 [PR build]

[vs-mobiletools-engineering-service2]

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: c86dcc9288847fe9827b97f4810132aa7efb27e3 [PR build]

[vs-mobiletools-engineering-service2]

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 1 tests failed, 106 tests passed.

Failures

❌ dotnettests tests (MacCatalyst) [attempt 2]

1 tests failed, 0 tests passed.

• DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 10 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: c86dcc9288847fe9827b97f4810132aa7efb27e3 [PR build]

[mandel-macaque]

The maccatalyst test failures are unrelated to the changes of PR PR: https://github.com/xamarin/maccore/issues/2965