Windows ISPC *For Consideration*

[derwin12]

For discussions only .. This is my local code for running ispc - nothing special.

removed the #ifndef WXMSW and the updated the vs2022 project files.

One thing is ispc compiled for what?
ispc.exe "%(FullPath)" -o "$(IntDir)%(Filename).obj" --target=host

This compiles based on my PC's capabilities - do we need to set that to a value that is our now new low-bar for cpu requirements.
What was used on the mac size?

[dkulp]

Most likely you want to use "--target=avx2-i32x16 --target=avx1-i32x16 --target=sse4.2-i32x8 --target=sse2-i32x8 --arch=x86_64" which is what is being used for Linux.. It compiles in all four and at runtime will select the one most appropriate based on the cpu.

[computergeek1507]

can you pull in my workflow change and to see if it builds on github

[derwin12]

I think I did what you asked ..
Can I run a build/installer script on my machine? Is that msw\build_VS_x64.cmd ?
Would that create a zip I can pass to others to test?

[derwin12]

Simple tests .. 5secs off of 60s render.

[computergeek1507]

You didn't merge in the GitHub action change to see if it compiles in github

[derwin12]

This latest push - I didnt have the HASISPC defined - I had it blocked out so it only did one file with ISPC.
I think it is in there .. I see the build ispc working..

Lets see the results of this next one. When I do release on my side now I am seeing upwards of 25-30% speed up.

[computergeek1507]

If it builds why not remove the the special "-ISPC" modifier and merge it, I can add the install code to the release and nightly action. If it works ship it.

[computergeek1507]

in a couple sequences I tried it decreased render time by 25%ish

[derwin12]

Nervous .. lol. It is 30% faster in these test I have been doing. I know there is one big bug with ISPC reported last night.
Lets test for a couple days but it should work. Not sure what Dan wants to do with the #ifdef stuff - just remove it??

[computergeek1507]

YOLO it, like the kids say

[cybercop23]

Can the layering bug be affecting the performance here? If it doesn't process layers, it will be faster. I see your PR is compiled, I'll download and test it this afternoon.

[derwin12]

Can the layering bug be affecting the performance here? If it doesn't process layers, it will be faster. I see your PR is compiled, I'll download and test it this afternoon.

Its only the 2 render styles .. but sure it might have some effect on the results.

[dkulp]

I think the main thing left to update before merging is the README.windows.